Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There should be an option to skip uploading Trace & Video. #98

Closed
scorypto opened this issue May 1, 2023 · 4 comments · Fixed by #102
Closed

There should be an option to skip uploading Trace & Video. #98

scorypto opened this issue May 1, 2023 · 4 comments · Fixed by #102
Assignees

Comments

@scorypto
Copy link

scorypto commented May 1, 2023

This option is needed as they can get bigger in size and upload request fails due to size.

@scorypto scorypto changed the title There should be an option to skip uploading Trace & Video as they can get bigger in size and upload request fails due to size. There should be an option to skip uploading Trace & Video. May 1, 2023
@AmsterGet AmsterGet self-assigned this May 22, 2023
@AmsterGet
Copy link
Member

AmsterGet commented May 22, 2023

Hello @scorypto !
I've implemented your request by adding two optional parameters to the agent config:
uploadVideo and uploadTrace.
In addition to this there is a possibility to control HTTP client options through restClientConfig agent parameter and specify f.e. maxBodyLength as an axios option.

@scorypto
Copy link
Author

Awesome. Thanks a lot. :)

@AmsterGet
Copy link
Member

I plan to release it this week with some small other improvements.
I'll notify you when it will be ready.

@AmsterGet
Copy link
Member

@scorypto
Published in agent-js-playwright 5.1.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants