-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests are hanging in an in progress state when retries is greater than 0 #85
Comments
Hello @costa-collibra ! |
Hi @AmsterGet Yes of course I am using: "@playwright/test": "1.31.0", Thanks for investigating |
@costa-collibra Did you have any errors in the console? |
I dont see any errors in this screenshot you can see 2 runs 1 with retries and 1 without. 1 completes and the other is stuck Here is the console output
|
@AmsterGet can you reproduce this error on your side? |
Hello @costa-collibra ! |
Hi
Yes indeed we have 2 tests with the fixme annotation which causes them to
be skipped.
Awesome work on reproducing that.
This is exactly our use case
|
Here is one of the tests test.fixme(
'@smoke Top Navigation should be visible (for new Homepage)',
async ({ homePage }) => {
const { topNavComponent } = homePage;
await topNavComponent.verifyTopNavIsVisible();
},
); |
@costa-collibra test('@smoke Top Navigation should be visible (for new Homepage)',
async ({ homePage }) => {
test.fixme();
const { topNavComponent } = homePage;
await topNavComponent.verifyTopNavIsVisible();
},
); Also I cannot reproduce the issue with Could you please recheck these two options on your side and confirm/decline them? |
@AmsterGet Interesting. So you this bug is only reproducible when:
test.fixme(
'@smoke Top Navigation should be visible (for new Homepage)',
async ({ homePage }) => {
const { topNavComponent } = homePage;
await topNavComponent.verifyTopNavIsVisible();
},
); If you just add My current deployment of report portal is currently down whilst we figure which team is going to take responsibility for it and that I have a meeting this afternoon. All being well we can have it back tomorrow and I can verify your questions, please bare with me till then :) |
@AmsterGet Hi The results are no longer hanging when i changed the syntax to this: test('@smoke Top Navigation should be visible (for new Homepage)', async ({
homePage,
}) => {
test.fixme();
const { topNavComponent } = homePage;
await topNavComponent.verifyTopNavIsVisible();
}); This is with retries set to 1 in the Playwright config. Most people do however use the other syntax. Will you be looking to fix this? In the meantime at least we have a workaround |
Hello @costa-collibra ! I've also added the issue troubleshooting section to the readme file with found workaround and link to this issue. Feel free to add your feedback on this :) |
@costa-collibra I've just released the new version 5.0.9 with some fixes that I've mentioned above. |
@AmsterGet thanks for this update. I will update the library today and feedback. If you can also tag me or send me a link to the issue when you log it with Playwright that would be great. If i can help with any feedback with them I would certainly be happy to do so |
@AmsterGet with your fix in can I go back to this code test.describe('Top Navigation Bar', () => {
test.fixme(
'@smoke Top Navigation should be visible (for new Homepage)',
async ({ homePage }) => {
const { topNavComponent } = homePage;
await topNavComponent.verifyTopNavIsVisible();
},
); or do i need to keep it inside the test |
@costa-collibra yes, you can try your previous solution. |
@AmsterGet it worked Thanks alot :) |
@AmsterGet I am seeing a similar behaviour. Some of it was fixed in latest version 5.0.11 but I think one case is missed and that is still causing Report portal to hang. If the test has test.fail() in it then tests seem to hang on report portal. |
@AmsterGet In this line - https://github.com/razorpay/frontend-website/pull/2044 |
@sumit-gupta91 |
Here is the config:
Report portal results just hang in progress and have to be force stopped.
However when retries is 0 it works.
Please can someone investigate?
The text was updated successfully, but these errors were encountered: