Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate block cursor to Layer and RectangleMarker API #137

Open
masad-frost opened this issue Aug 8, 2023 · 0 comments
Open

Migrate block cursor to Layer and RectangleMarker API #137

masad-frost opened this issue Aug 8, 2023 · 0 comments

Comments

@masad-frost
Copy link
Member

https://github.com/replit/codemirror-vim/blob/master/src/block-cursor.ts copied the implementation of codemirror's selection, somewhere around this version https://github.com/codemirror/view/blob/0.19.27/src/draw-selection.ts. Most of the magic has since been moved to a public API https://github.com/codemirror/view/blob/6.16.0/src/draw-selection.ts#L4

I think using those primitives will simplify the implementation and make it more maintainable.

@masad-frost masad-frost changed the title Migrate block cursor to Layer and RectanguleMarker API Migrate block cursor to Layer and RectangleMarker API Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant