Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pangolin v4.0 #220

Closed
hoelzer opened this issue Mar 30, 2022 · 11 comments · Fixed by #224
Closed

Pangolin v4.0 #220

hoelzer opened this issue Mar 30, 2022 · 11 comments · Fixed by #224
Assignees
Labels
documentation Improvements or additions to documentation enhancement New feature or request

Comments

@hoelzer
Copy link
Collaborator

hoelzer commented Mar 30, 2022

There will be an update that changes the way pangoLEARN, etc... are used and aims to harmonize all that stuff into a single pangolin-data dependency:

Another thing that will impact this is that pangolin 4.0 is due to be released this week at some point, and that will change the versioning system to be less convoluted than the current one.

In pangolin 4.0, a new dependency pangolin-data will replace the current pangoLEARN and pango-designation dependencies. With this update, the pangolin-data version number will always be the same as the pango-designation version the model was trained on and the usher tree was built on. That removes the conflicting pango-designation versions reported and also removes the pangoLEARN dated versioning system, leaving only a single version that corresponds directly to the version of lineages used in the data.

cov-lineages/pangolin#386 (comment)

We should be aware of that and might have to change some code (version numbers, report, ...) when this update happens.

@hoelzer hoelzer added documentation Improvements or additions to documentation enhancement New feature or request labels Mar 30, 2022
@replikation
Copy link
Owner

yep this might need some adjustments on final report @RaverJay but will simplify the overview

@hoelzer
Copy link
Collaborator Author

hoelzer commented Apr 1, 2022

Example output of the new version:

cov-lineages/pangolin#390

@hoelzer
Copy link
Collaborator Author

hoelzer commented Apr 1, 2022

Great overview of the changes: https://cov-lineages.org/resources/pangolin/pipeline.html

@RaverJay
Copy link
Collaborator

RaverJay commented Apr 1, 2022

Looks great, this will simplify things a lot

@hoelzer
Copy link
Collaborator Author

hoelzer commented Apr 1, 2022

And a nice thread summarizing the main changes again

https://twitter.com/AineToole/status/1509876534529638411

@RaverJay
Copy link
Collaborator

RaverJay commented Apr 1, 2022

@replikation when will the container be ready? :)

@hoelzer
Copy link
Collaborator Author

hoelzer commented Apr 1, 2022

@replikation when will the container be ready? :)

I guess at the moment when the new pango v4.0 is on bioconda :D

@replikation
Copy link
Owner

replikation commented Apr 1, 2022

No we are building from git directly to avoid delays @hoelzer. but the auto builds have a few checks to not cause an issue on poreCov (e.g. are the columns present - and it currently tags via pangolin and pangolearn version). this might be a bit annoying now to switch the whole thing in combination with porecov. (e.g. --update might break now older poreCov versions). SO i might need to fork and create a "pangolin4" container going forward or so. need to check first

Edit: yes the column headers are changed. need to create a new pangolin fork to avoid issues

@replikation
Copy link
Owner

@RaverJay i guess the html report creates an error if it cant get the correct versions?

@hoelzer
Copy link
Collaborator Author

hoelzer commented Apr 1, 2022

uhh, you're right @replikation I thought we build from bioconda. Ah yes, and now basically older versions of poreCov can only use pangolin containers until a certain release. Okay, that's a bit annoying -.-

@RaverJay
Copy link
Collaborator

RaverJay commented Apr 1, 2022

@RaverJay i guess the html report creates an error if it cant get the correct versions?

Yes, it will fail when the columns it needs are not there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants