-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recommend installing xz
if it's missing
#619
Conversation
🦋 Changeset detectedLatest commit: 929ef09 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
throw new Error("Unable to extract browser archive"); | ||
let message = "Unable to extract browser archive"; | ||
|
||
if (!hasXz) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's tempting to suggest some concrete installation instructions for this but it might differ based on the linux distro used and other factors
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love it.
let message = "Unable to extract browser archive"; | ||
|
||
if (!hasXz) { | ||
message += `. xz is required to decompress it. Please install xz and try again.`; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if this should say "XZ Utils" or something more than just "xy" ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is tricky because in some distros the proper thing to install is xz
... and they say that JS dependency management is a mess 🤷♂️
No description provided.