From 8030662c892dfc377df449392e4d75dabff1ccd0 Mon Sep 17 00:00:00 2001 From: Aditya Pandey Date: Tue, 25 Jun 2024 18:09:33 -0500 Subject: [PATCH] Remove `cli-multipart-upload` flag --- packages/replay/src/main.ts | 3 +-- .../replayio/src/utils/recordings/upload/uploadRecording.ts | 5 ++--- .../replayio/src/utils/recordings/upload/uploadRecordings.ts | 3 +-- 3 files changed, 4 insertions(+), 7 deletions(-) diff --git a/packages/replay/src/main.ts b/packages/replay/src/main.ts index 93dd6ea4b..e34ce1940 100644 --- a/packages/replay/src/main.ts +++ b/packages/replay/src/main.ts @@ -341,8 +341,7 @@ async function doUploadRecording( let recordingId: string; try { - const isMultipartEnabled = await getLaunchDarkly().isEnabled("cli-multipart-upload", false); - if (size > MIN_MULTIPART_UPLOAD_SIZE && isMultipartEnabled) { + if (size > MIN_MULTIPART_UPLOAD_SIZE) { recordingId = await multipartUploadRecording( server, client, diff --git a/packages/replayio/src/utils/recordings/upload/uploadRecording.ts b/packages/replayio/src/utils/recordings/upload/uploadRecording.ts index 0fdc71a2c..983cf36e4 100644 --- a/packages/replayio/src/utils/recordings/upload/uploadRecording.ts +++ b/packages/replayio/src/utils/recordings/upload/uploadRecording.ts @@ -27,14 +27,13 @@ export async function uploadRecording( client: ProtocolClient, recording: LocalRecording, options: { - multiPartUpload: boolean; processingBehavior: ProcessingBehavior; } ) { const { buildId, id, path } = recording; assert(path, "Recording path is required"); - const { multiPartUpload, processingBehavior } = options; + const { processingBehavior } = options; const { size } = await stat(path); @@ -45,7 +44,7 @@ export async function uploadRecording( recording.uploadStatus = "uploading"; try { - if (multiPartUpload && size > multiPartMinSizeThreshold) { + if (size > multiPartMinSizeThreshold) { const { chunkSize, partLinks, recordingId, uploadId } = await beginRecordingMultipartUpload( client, { diff --git a/packages/replayio/src/utils/recordings/upload/uploadRecordings.ts b/packages/replayio/src/utils/recordings/upload/uploadRecordings.ts index efe7e95be..ab5d09495 100644 --- a/packages/replayio/src/utils/recordings/upload/uploadRecordings.ts +++ b/packages/replayio/src/utils/recordings/upload/uploadRecordings.ts @@ -39,7 +39,6 @@ export const uploadRecordings = withTrackAsyncEvent( return []; } - const multiPartUpload = await getFeatureFlagValue("cli-multipart-upload", false); const client = new ProtocolClient(); try { await client.waitUntilAuthenticated(); @@ -70,7 +69,7 @@ export const uploadRecordings = withTrackAsyncEvent( } else { return createSettledDeferred( recording, - uploadRecording(client, recording, { multiPartUpload, processingBehavior }) + uploadRecording(client, recording, { processingBehavior }) ); } });