Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Repeater implement AsyncGenerator type and parameterize Return/Next types #17

Closed
brainkim opened this issue Jun 10, 2019 · 1 comment · Fixed by #30
Closed

Make Repeater implement AsyncGenerator type and parameterize Return/Next types #17

brainkim opened this issue Jun 10, 2019 · 1 comment · Fixed by #30
Assignees
@brainkim
Labels
enhancement New feature or request

Comments

@brainkim
Copy link
Member

brainkim commented Jun 10, 2019 •
edited
Loading

The next version of typescript will include types for AsyncGenerator which parameterize the values passed to next and return. Blocked by microsoft/TypeScript#30790
@brainkim brainkim changed the title Parameterize return/next types and make Channel implement AsyncGenerator type once it’s published Make Channel implement AsyncGenerator type and parameterize Return/Next types. Jun 10, 2019
@brainkim brainkim added the enhancement New feature or request label Aug 12, 2019
@brainkim brainkim added help wanted Extra attention is needed good first issue Good for newcomers labels Aug 28, 2019
@brainkim
Copy link
Member Author

Probably can work on this now that typescript 3.6 has been released. Need to figure out how to support typescript version < 3.6, maybe using a type polyfill similar to the unknown type polyfill.

@brainkim brainkim removed the good first issue Good for newcomers label Sep 1, 2019
@brainkim brainkim self-assigned this Sep 1, 2019
@brainkim brainkim removed the help wanted Extra attention is needed label Sep 1, 2019
@brainkim brainkim mentioned this issue Sep 10, 2019
Merged
@brainkim brainkim changed the title Make Channel implement AsyncGenerator type and parameterize Return/Next types. Make Repeater implement AsyncGenerator type and parameterize Return/Next types Oct 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brainkim brainkim

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Parameterize next/return repeaterjs/repeater
1 participant
@brainkim