Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: try vitest #24302

Closed
wants to merge 4 commits into from
Closed

test: try vitest #24302

wants to merge 4 commits into from

Conversation

viceice
Copy link
Member

@viceice viceice commented Sep 7, 2023

Changes

First try on vitest

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@HonkingGoose HonkingGoose added the status:blocked Issue is blocked by another issue or external requirement label Sep 7, 2023
@HonkingGoose
Copy link
Collaborator

Hi @viceice, the issue you marked as a blocker is fixed now. So you may want to try this PR again, with a newer version of the esbuild dependency.

@HonkingGoose HonkingGoose removed the status:blocked Issue is blocked by another issue or external requirement label Jan 25, 2024
@viceice
Copy link
Member Author

viceice commented Jan 26, 2024

thanks, as always running out of time 🙈

@HonkingGoose
Copy link
Collaborator

@viceice do you want to keep this PR open?

It's been a while since you commited to the branch. I guess it's easier to start fresh on a new branch, instead of fixing the merge conflicts. 😄

@viceice viceice closed this May 8, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Try Vitest test runner on this repository
2 participants