From b94b0bd00372133911087bca0e5bd9ab1403282a Mon Sep 17 00:00:00 2001 From: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com> Date: Mon, 12 Jun 2023 20:59:06 +0200 Subject: [PATCH 1/9] docs(node.js versioning): rewrite --- lib/modules/versioning/node/readme.md | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/lib/modules/versioning/node/readme.md b/lib/modules/versioning/node/readme.md index b53137c719d995..180204c938c8ee 100644 --- a/lib/modules/versioning/node/readme.md +++ b/lib/modules/versioning/node/readme.md @@ -1,3 +1,5 @@ -Renovate's Node.js versioning is a wrapper around npm's versioning, except that it makes sure to strip "v" prefixes from exact versions when replacing. +Renovate's Node.js versioning is a wrapper around npm's versioning. +But Renovate removes any `v` prefixes from exact versions when replacing. -It is planned to extend it one day to support "stability" awareness, because Node.js's version stability does not follow the SemVer approach. +We plan to extend the Node.js versioning to support "stability" awareness. +This is nice to have because Node.js's version stability does not match the SemVer rules. From 2f39c55d643386e824a45b2514c6ccdace249b7f Mon Sep 17 00:00:00 2001 From: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com> Date: Sat, 16 Sep 2023 10:10:30 +0200 Subject: [PATCH 2/9] Apply suggestions from code review Co-authored-by: Rhys Arkins --- lib/modules/versioning/node/readme.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/modules/versioning/node/readme.md b/lib/modules/versioning/node/readme.md index 180204c938c8ee..52978453b12a2b 100644 --- a/lib/modules/versioning/node/readme.md +++ b/lib/modules/versioning/node/readme.md @@ -1,5 +1,5 @@ -Renovate's Node.js versioning is a wrapper around npm's versioning. -But Renovate removes any `v` prefixes from exact versions when replacing. +Renovate's Node.js versioning is a wrapper around npm versioning. +But Renovate removes any `v` prefixes from semantic versions when replacing. We plan to extend the Node.js versioning to support "stability" awareness. This is nice to have because Node.js's version stability does not match the SemVer rules. From ce89d371b57ca301f40acf0043756f00ab0c9c78 Mon Sep 17 00:00:00 2001 From: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com> Date: Sat, 16 Sep 2023 10:12:09 +0200 Subject: [PATCH 3/9] Drop text about future feature --- lib/modules/versioning/node/readme.md | 2 -- 1 file changed, 2 deletions(-) diff --git a/lib/modules/versioning/node/readme.md b/lib/modules/versioning/node/readme.md index 52978453b12a2b..7f205ff232253c 100644 --- a/lib/modules/versioning/node/readme.md +++ b/lib/modules/versioning/node/readme.md @@ -1,5 +1,3 @@ Renovate's Node.js versioning is a wrapper around npm versioning. But Renovate removes any `v` prefixes from semantic versions when replacing. -We plan to extend the Node.js versioning to support "stability" awareness. -This is nice to have because Node.js's version stability does not match the SemVer rules. From 120ecb9af5333c833ba30dc0c865903d1e6acd35 Mon Sep 17 00:00:00 2001 From: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com> Date: Sat, 16 Sep 2023 10:20:13 +0200 Subject: [PATCH 4/9] Drop extra newline --- lib/modules/versioning/node/readme.md | 1 - 1 file changed, 1 deletion(-) diff --git a/lib/modules/versioning/node/readme.md b/lib/modules/versioning/node/readme.md index 7f205ff232253c..f1dd865eebd635 100644 --- a/lib/modules/versioning/node/readme.md +++ b/lib/modules/versioning/node/readme.md @@ -1,3 +1,2 @@ Renovate's Node.js versioning is a wrapper around npm versioning. But Renovate removes any `v` prefixes from semantic versions when replacing. - From 1e91e3aa4d7811211f611a87ef2f11c603d48048 Mon Sep 17 00:00:00 2001 From: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com> Date: Mon, 18 Sep 2023 10:05:39 +0200 Subject: [PATCH 5/9] Apply suggestions from code review Co-authored-by: Rhys Arkins --- lib/modules/versioning/node/readme.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/lib/modules/versioning/node/readme.md b/lib/modules/versioning/node/readme.md index f1dd865eebd635..28c50853a2aa28 100644 --- a/lib/modules/versioning/node/readme.md +++ b/lib/modules/versioning/node/readme.md @@ -1,2 +1,6 @@ Renovate's Node.js versioning is a wrapper around npm versioning. But Renovate removes any `v` prefixes from semantic versions when replacing. + +Its primary purpose is to add Node.js LTS awareness, e.g. +- Odd releases are unstable +- Even releases do not reach stability (LTS) immediately From 14f228cd1cb642d3165158fea50ae4d42da91b76 Mon Sep 17 00:00:00 2001 From: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com> Date: Mon, 18 Sep 2023 10:06:12 +0200 Subject: [PATCH 6/9] Small style fixes --- lib/modules/versioning/node/readme.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/modules/versioning/node/readme.md b/lib/modules/versioning/node/readme.md index 28c50853a2aa28..436c19ede6df53 100644 --- a/lib/modules/versioning/node/readme.md +++ b/lib/modules/versioning/node/readme.md @@ -1,6 +1,7 @@ Renovate's Node.js versioning is a wrapper around npm versioning. But Renovate removes any `v` prefixes from semantic versions when replacing. -Its primary purpose is to add Node.js LTS awareness, e.g. +Its primary purpose is to add Node.js LTS awareness, e.g.: + - Odd releases are unstable - Even releases do not reach stability (LTS) immediately From 495e18bf59741bca3f51c27328524b7a94cf561d Mon Sep 17 00:00:00 2001 From: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com> Date: Mon, 18 Sep 2023 10:21:18 +0200 Subject: [PATCH 7/9] Update lib/modules/versioning/node/readme.md Co-authored-by: Rhys Arkins --- lib/modules/versioning/node/readme.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lib/modules/versioning/node/readme.md b/lib/modules/versioning/node/readme.md index 436c19ede6df53..41b323a87aba09 100644 --- a/lib/modules/versioning/node/readme.md +++ b/lib/modules/versioning/node/readme.md @@ -5,3 +5,6 @@ Its primary purpose is to add Node.js LTS awareness, e.g.: - Odd releases are unstable - Even releases do not reach stability (LTS) immediately + + +Unfortunately there is not currently any way to get `node` versioning to replace `docker` versioning when Docker image tags contain a compatibility suffix such as `-alpine` or `-slim`, because npm versioning treats these suffixes as implying pre-releases. From 39c3607cd054c23c8bbc390983875d522d4b3b56 Mon Sep 17 00:00:00 2001 From: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com> Date: Mon, 18 Sep 2023 10:22:00 +0200 Subject: [PATCH 8/9] Fix whitespace --- lib/modules/versioning/node/readme.md | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/lib/modules/versioning/node/readme.md b/lib/modules/versioning/node/readme.md index 41b323a87aba09..c05c9708f137c4 100644 --- a/lib/modules/versioning/node/readme.md +++ b/lib/modules/versioning/node/readme.md @@ -6,5 +6,4 @@ Its primary purpose is to add Node.js LTS awareness, e.g.: - Odd releases are unstable - Even releases do not reach stability (LTS) immediately - -Unfortunately there is not currently any way to get `node` versioning to replace `docker` versioning when Docker image tags contain a compatibility suffix such as `-alpine` or `-slim`, because npm versioning treats these suffixes as implying pre-releases. +Unfortunately, there is not currently any way to get `node` versioning to replace `docker` versioning when Docker image tags contain a compatibility suffix such as `-alpine` or `-slim`, because npm versioning treats these suffixes as implying pre-releases. From f876bdb5076f88750047ccceb849bb7c58631a6f Mon Sep 17 00:00:00 2001 From: Rhys Arkins Date: Mon, 18 Sep 2023 13:27:30 +0200 Subject: [PATCH 9/9] Update lib/modules/versioning/node/readme.md Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com> --- lib/modules/versioning/node/readme.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/modules/versioning/node/readme.md b/lib/modules/versioning/node/readme.md index c05c9708f137c4..678c9d36f68f8a 100644 --- a/lib/modules/versioning/node/readme.md +++ b/lib/modules/versioning/node/readme.md @@ -6,4 +6,5 @@ Its primary purpose is to add Node.js LTS awareness, e.g.: - Odd releases are unstable - Even releases do not reach stability (LTS) immediately -Unfortunately, there is not currently any way to get `node` versioning to replace `docker` versioning when Docker image tags contain a compatibility suffix such as `-alpine` or `-slim`, because npm versioning treats these suffixes as implying pre-releases. +You can _not_ use `node` versioning to replace `docker` versioning if you are using node tags with suffixes like `-alpine`. +This is because npm versioning treats these suffixes as implying pre-releases/instability.