Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(presets): create approveMajorUpdates #22075

Merged
merged 5 commits into from
May 18, 2023
Merged

feat(presets): create approveMajorUpdates #22075

merged 5 commits into from
May 18, 2023

Conversation

HonkingGoose
Copy link
Collaborator

@HonkingGoose HonkingGoose commented May 10, 2023 •
edited
Loading

Changes

  • Create approveMajorUpdates preset

Context

Inspired by:

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@HonkingGoose HonkingGoose mentioned this pull request May 10, 2023
Merged
6 tasks
HonkingGoose
HonkingGoose commented May 10, 2023
View reviewed changes
lib/config/presets/internal/default.ts Outdated Show resolved Hide resolved
lib/config/presets/internal/default.ts Outdated Show resolved Hide resolved
@HonkingGoose HonkingGoose requested a review from rarkins May 17, 2023 08:03
@rarkins
Copy link
Collaborator

rarkins commented May 17, 2023

Ideas:

  • approveMajorUpdates
  • requireApprovalForMajor
  • majorUpdatesNeedApproval

@HonkingGoose HonkingGoose changed the title feat(presets): create dependencyDashboardApprovalForMajor feat(presets): create approveMajorUpdates May 17, 2023
@HonkingGoose HonkingGoose marked this pull request as ready for review May 17, 2023 09:36
@HonkingGoose HonkingGoose requested review from rarkins and removed request for rarkins May 17, 2023 09:36
@rarkins rarkins added this pull request to the merge queue May 18, 2023
Merged via the queue into renovatebot:main with commit 4528048 May 18, 2023
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 35.94.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@HonkingGoose HonkingGoose deleted the feat/dependency-dashboard-approval-major-preset branch May 18, 2023 08:26
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rarkins rarkins rarkins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HonkingGoose @rarkins @renovate-release