Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(presets): add config:best-practices preset #21239

Merged
merged 19 commits into from
Jul 2, 2023
Merged

feat(presets): add config:best-practices preset #21239

Changes from all commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
58e2f99
feat(presets): add config:bast-practice preset
DuncanCasteleyn Mar 29, 2023
77cab58
fix: Apply suggested description
DuncanCasteleyn Mar 30, 2023
10c30e9
fix: Use plural
DuncanCasteleyn Apr 1, 2023
59365b0
Merge branch 'main' into preset/best-practice
DuncanCasteleyn Apr 1, 2023
1c2ef86
Merge branch 'main' into preset/best-practice
DuncanCasteleyn Apr 7, 2023
a25488a
Merge branch 'main' into preset/best-practice
DuncanCasteleyn Apr 27, 2023
f7dba54
Merge branch 'main' into preset/best-practice
DuncanCasteleyn May 8, 2023
37515b3
fix(presets): use preset to pin dev dependencies
DuncanCasteleyn May 9, 2023
cce9c33
Merge branch 'main' into preset/best-practice
DuncanCasteleyn May 9, 2023
683329a
feat: enable configMigration
DuncanCasteleyn May 10, 2023
53cdf4c
fix(presets): fix lint issue
DuncanCasteleyn May 10, 2023
adcbd3b
Merge branch 'main' into preset/best-practice
DuncanCasteleyn May 10, 2023
916e825
Merge branch 'main' into preset/best-practice
DuncanCasteleyn May 12, 2023
deb1d9a
Merge branch 'main' into preset/best-practice
DuncanCasteleyn May 15, 2023
f23363e
Merge branch 'main' into preset/best-practice
DuncanCasteleyn Jun 4, 2023
6735bf2
Merge branch 'main' into preset/best-practice
DuncanCasteleyn Jun 16, 2023
1e0e96f
Merge branch 'main' into preset/best-practice
DuncanCasteleyn Jun 24, 2023
4278ee3
Merge branch 'main' into preset/best-practice
DuncanCasteleyn Jun 27, 2023
da831df
Merge branch 'main' into preset/best-practice
DuncanCasteleyn Jul 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions lib/config/presets/internal/config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,16 @@ export const presets: Record<string, Preset> = {
'workarounds:all',
DuncanCasteleyn marked this conversation as resolved.
Show resolved Hide resolved
],
},
'best-practices': {
DuncanCasteleyn marked this conversation as resolved.
Show resolved Hide resolved
configMigration: true,
description: 'Preset with best practices from the Renovate maintainers.',
extends: [
'config:base',
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@viceice This should be 'config:recommended', or? I noticed that in documentation. Not sure what should be updated. Only this file and docs will be generate automatically?

Copy link
Collaborator

@HonkingGoose HonkingGoose Jul 7, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The config:best-practices preset still uses config:base in the current main branch:

renovate/lib/config/presets/internal/config.ts

Lines 1 to 15 in c89eeb8

import type { Preset } from '../types';
/* eslint sort-keys: ["error", "asc", {caseSensitive: false, natural: true}] */
export const presets: Record<string, Preset> = {
'best-practices': {
configMigration: true,
description: 'Preset with best practices from the Renovate maintainers.',
extends: [
'config:base',
'docker:pinDigests',
'helpers:pinGitHubActionDigests',
':pinDevDependencies',
],
},

I think this was caused because we merged the config:best-practices preset to main before we merged the config:base -> config:recommended PR. The config:base rename PR didn't fix up this file.

'docker:pinDigests',
'helpers:pinGitHubActionDigests',
':pinDevDependencies',
],
},
'js-app': {
description: 'Default configuration for webapps.',
extends: ['config:base', ':pinAllExceptPeerDependencies'],
Expand Down