Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Prevent uninitialized cacheProxy from being accessed in cleanup #20975

Merged
merged 2 commits into from
Mar 16, 2023
Merged

fix: Prevent uninitialized cacheProxy from being accessed in cleanup #20975

merged 2 commits into from
Mar 16, 2023

Conversation

JohnDaly
Copy link
Contributor

@JohnDaly JohnDaly commented Mar 16, 2023 •
edited
Loading

Changes

Updating cleanup function to check if cacheProxy.cleanup exists by using cacheProxy?.cleanup.

Context

It's possible that cacheProxy might not be initialized when cleanup is called, which would result in the following error:

TypeError: Cannot read properties of undefined (reading 'cleanup')

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@CLAassistant
Copy link

CLAassistant commented Mar 16, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@rarkins rarkins enabled auto-merge March 16, 2023 04:34
@rarkins rarkins added this pull request to the merge queue Mar 16, 2023
Merged via the queue into renovatebot:main with commit 15c7e8d Mar 16, 2023
@JohnDaly JohnDaly deleted the fix/cache-proxy-cleanup branch March 16, 2023 06:21
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 35.9.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@nikolaik nikolaik mentioned this pull request Mar 23, 2023
Merged
6 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rarkins rarkins rarkins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JohnDaly @CLAassistant @renovate-release @rarkins