Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update node.js version supportPolicy table #7501

Merged
merged 3 commits into from
Oct 20, 2020

Conversation

HonkingGoose
Copy link
Collaborator

@HonkingGoose HonkingGoose commented Oct 19, 2020

Changes:

Context:

Can you please check my work, it was hard to figure out the Node.js versions that should go in each row of the table.

Closes #7497

Am I using the right conventional commit message?

I hope I'm using the right conventional commit message (I have never used conventional commits before...).

Feedback on first getting started contributing

I was a bit of work getting started, but it was well documented on how to get started with the work.
I ran all the tests by first installing everything with yarn install then made a basic build with yarn build, then ran yarn test, and finally confirmed that yarn start gives the correct error message.

@rarkins rarkins merged commit b1d474e into renovatebot:master Oct 20, 2020
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 23.53.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@HonkingGoose HonkingGoose deleted the fix/7497 branch October 20, 2020 07:40
@HonkingGoose
Copy link
Collaborator Author

Thanks for merging in my work! 😄 🎉

@viceice
Copy link
Member

viceice commented Oct 20, 2020

Thanks for your help. ❤️

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Outdated Node.js table in Configuring Support Policy docs
5 participants