Renovate removed a or clause when updating node engines in package.json

[jelhan]

What Renovate type, platform and version are you using?

I'm using hosted Renovate on GitHub.

Describe the bug

Renoate tried to update Node.js 10.* to 10.* >= v10.22.1. This only affected one side of an OR (||) condition: 10.* || >= 12 Renovate dropped the other part of the OR condition without warning.

Instead of updating to 10.* >= v10.22.1 || >= 12 it changed to 10.* >= v10.22.1 and therefore dropped support for node 12 and later.

Relevant debug logs

Please see this pull request created by Renovate: https://github.com/jelhan/ember-autoresize-modifier/pull/61/files

[viceice]

10.* || >= 12 looks ugly to me. is that a valid range? shouldn't this be something like ^10 || >= 12 ?

[viceice]

also related to #2084

[rarkins]

Strange. Is it reproducible in a simple repo?

[jelhan]

10.* || >= 12 looks ugly to me. is that a valid range? shouldn't this be something like ^10 || >= 12 ?

This is the syntax used by Ember CLI to generate new Ember.js projects: https://github.com/ember-cli/ember-new-output/blob/ed88fd1f967a17887d94ae911eaa7283e713e088/package.json#L55 Ember.js is a well established JavaScript framework to create single page applications. Not arguing what range might be better. Just wanted to point out that this engines configuration is used by many enterprise applications in production.

Is it reproducible in a simple repo?

What do you mean by simple repo? I would consider the repository linked a simple one. 😉

[rarkins]

A simple repository is one with minimum possible files to reproduce the problem.

[jelhan]

I haven't had the time to setup a reproduction but I noticed that another repository is affected as well: https://github.com/jelhan/croodle/pull/421/files

[github-actions]

Hi there,

Get your issue fixed faster by creating a minimal reproduction. This means a repository dedicated to reproducing this issue with the minimal dependencies and config possible.

Before we start working on your issue we need to know exactly what's causing the current behavior. A minimal reproduction helps us with this.

To get started, please read our guide on creating a minimal reproduction.

We may close the issue if you, or someone else, haven't created a minimal reproduction within two weeks. If you need more time, or are stuck, please ask for help or more time in a comment.

Good luck,

The Renovate team

[github-actions]

When a bug has been marked as needing a reproduction, it means nobody can work on it until one is provided. In cases where no reproduction is possible, or the issue creator does not have the time to reproduce, we unfortunately need to close such issues as they are non-actionable and serve no benefit by remaining open. This issue will be closed after 7 days of inactivity.

[github-actions]

This bug report has been closed as we need a reproduction to work on this. If the original poster or anybody else with the same problem discovers that they can reproduce it, please create a new issue, and reference this issue.