feat: add github-actions tag support #7434
Conversation
| Object { | ||
| "currentValue": "v1.0.0", | ||
| "datasource": "github-tags", | ||
| "depName": "actions/bin/shellcheck", |
There was a problem hiding this comment.
I don't think this is valid tags - perhaps needs lookupName? Also github.com/actions/bin doesn't exist either?
There was a problem hiding this comment.
Ha, that's fair. I'll update the examples to something more realistic and maybe add a path nesting limit.
There was a problem hiding this comment.
if it's a/b/c then the a/b represents the repo while c is file or folder name? And if there's multiple actions within one repo then they share the same tags? Ie tags are per repo and not per action?
There was a problem hiding this comment.
Hmmm. While actions technically supports repo subpaths, the recommendation is to have a single action per repo. At least for this first pass of getting this working, I wouldn't support the path'd version as the way most people would likely use that is via SHAs and not tags. Or would require some sort of tag prefixing support.
There was a problem hiding this comment.
If it's technically possible then we should ideally support it. In this case the lookupName would be a/b
There was a problem hiding this comment.
I actually did end up doing this. The latest version of the regex will extract owner/repo and ignore the path.
|
Went ahead and improved the regex. It'll tolerate and ignore sub paths and tolerate more actual repo names, prefers loose versioning (which is more correct?), and fixes tag to be lookupName instead of depName, which appears to be what |
| depName: dep.depName, | ||
| currentValue: dep.currentValue, |
There was a problem hiding this comment.
| depName: dep.depName, | |
| currentValue: dep.currentValue, | |
| dep, |
There was a problem hiding this comment.
All the other examples were abbreviated, so wasn't sure. Changed
There was a problem hiding this comment.
ah, i see now. some manager log the dep and some not. 🤔
@rarkins Should we pefer to remove the logging or should we add those logging to all managers? Maybe log at trace level?
There was a problem hiding this comment.
No, we ideally shouldn't have that in managers as it bloats the logs. We should convert them to trace
|
Looking at other managers, should I specify |
I don't think so. |
|
Switched to |
Co-authored-by: Rhys Arkins <[email protected]>
|
@RichiCoder1 have you tested this latest code against any "real" repos? |
I've been running a regex-ified version against two of my repos with no issues (using docker & github tags). Gotten some updates, no big issues so far. We have pretty minor, sane usage though. |
|
Let's make sure we have tested it against:
|
| logger.debug( | ||
| { | ||
| depName: dep.depName, | ||
| currentValue: dep.currentValue, | ||
| currentDigest: dep.currentDigest, | ||
| }, | ||
| 'Docker image inside GitHub Actions' | ||
| 'Docker image inside GitHub Workflow' | ||
| ); |
| if (!dockerVersioning.api.isValid(currentValue)) { | ||
| dep.skipReason = SkipReason.InvalidVersion; | ||
| } | ||
| logger.trace(dep, 'GitHub Action inside GitHub Workflow'); |
There was a problem hiding this comment.
| logger.trace(dep, 'GitHub Action inside GitHub Workflow'); |
As we discussed, managers don't newed to log this, as all deps will be logged later anyways.
…n of GitHub Actions Waiting on renovatebot/renovate#7434
|
I'll merge this once the current release is done |
|
🎉 This PR is included in version 23.55.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
|
Will Renovate now start to update actions tags automatically or do I have to configure it to do so? |
Yes, but the whitesource app is not yet updated, will be done today. So you shouldn't have to do anything. |
|
@rarkins 🥳 Glad I could help with this! Sorry I couldn't help more with testing |
Adds support for GitHub Action tag versions in GitHub Action Workflow Files.
Removes deprecated old-style workflow support.
Not include:
Closes #5733