Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: convert sourceDirectory to a template eligible config #32701

Merged
merged 7 commits into from
Nov 26, 2024

Conversation

setchy
Copy link
Collaborator

@setchy setchy commented Nov 24, 2024

Changes

Convert sourceDirectory to be a template eligible field.

Demonstration repo: https://github.com/setchy/renovate-atlaskit-changelog-two

Context

Help with monorepo package updates where there is a source folder pattern based upon the package name.

For example using https://bitbucket.org/atlassian/atlassian-frontend-mirror and their design-system packages

{
  "extends": ["packages:atlaskit"],
  "sourceUrl": "https://bitbucket.org/atlassian/atlassian-frontend-mirror",
  "sourceDirectory": "design-system/{{ lookup (split packageName '/') 1 }}"
}

As opposed to setting source directory for each of the ~50+ packages, ie 😅 https://github.com/setchy/renovate-atlaskit-changelog/blob/main/renovate.json

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@setchy setchy marked this pull request as ready for review November 24, 2024 15:20
@setchy setchy changed the title feat(templates): enable templates for sourceDirectory feat: convert sourceDirectory to a template eligible config Nov 24, 2024
@setchy setchy marked this pull request as draft November 25, 2024 13:50
@setchy setchy marked this pull request as ready for review November 25, 2024 20:13
@setchy setchy requested a review from rarkins November 25, 2024 21:08
@rarkins rarkins added this pull request to the merge queue Nov 26, 2024
Merged via the queue into renovatebot:main with commit 74c87b4 Nov 26, 2024
55 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 39.31.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

ssams pushed a commit to ssams/renovate that referenced this pull request Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants