Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bundler): add inline source support #32600

Merged
merged 2 commits into from
Nov 20, 2024

Conversation

Djiit
Copy link
Contributor

@Djiit Djiit commented Nov 18, 2024

Changes

Here I'm adding support for "inline source" declaration, that is when a user declare a one-off source for a specific gem.

Context

While working on supporting variables, it appears that inline sources were not supported.

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@Djiit Djiit marked this pull request as ready for review November 18, 2024 16:39
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Djiit
Copy link
Contributor Author

Djiit commented Nov 18, 2024

@viceice Thanks, I pushed the missing tests. For my knowledge, what's an easy way to check this locally (which line are not covered) instead of waiting for the codecov report?

@Djiit Djiit requested a review from viceice November 18, 2024 18:59
@viceice viceice added the auto:no-mentions Don't cause unnecessary notifications label Nov 19, 2024
Copy link
Contributor

Hi there,

This is intended as a polite, automated request that users avoid @ mentioning repository maintainers like @rarkins or @viceice. Doing so causes annoying mobile notifications and makes it harder to maintain this repository.

We know it might be common elsewhere but we participate in hundreds of discussions a week and would need to turn off GitHub mobile notifications if we were mentioned in every one.

As a general rule, we will read and respond to all discussions in this repository, so there is no need to mention us.

Thanks, the Renovate team

@viceice
Copy link
Member

viceice commented Nov 19, 2024

@viceice Thanks, I pushed the missing tests. For my knowledge, what's an easy way to check this locally (which line are not covered) instead of waiting for the codecov report?

run pnpm jest <path-to-folder> and check coverage folder

@rarkins rarkins added this pull request to the merge queue Nov 20, 2024
Merged via the queue into renovatebot:main with commit 8e52625 Nov 20, 2024
40 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 39.21.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

ssams pushed a commit to ssams/renovate that referenced this pull request Dec 2, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
auto:no-mentions Don't cause unnecessary notifications
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants