Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support updating oci artifacts in bzlmod (rules_oci oci.pull) #32526

Closed
rarkins opened this issue Nov 14, 2024 Discussed in #31895 · 1 comment · Fixed by #32453
Closed

Support updating oci artifacts in bzlmod (rules_oci oci.pull) #32526

rarkins opened this issue Nov 14, 2024 Discussed in #31895 · 1 comment · Fixed by #32453
Labels
manager:bzlmod Related to the bzlmod manager priority-4-low Low priority, unlikely to be done unless it becomes important to more people type:feature Feature (new functionality)

Comments

@rarkins
Copy link
Collaborator

rarkins commented Nov 14, 2024

Discussed in #31895

Originally posted by punsoong-canva October 10, 2024

Tell us more.

Renovate already supports updating dependencies pulled in with rules_oci and oci_pull in legacy WORKSPACE files (https://docs.renovatebot.com/bazel/#legacy-workspace-files)

Similar to #27467, I would like Renovate to support updating oci artifacts when oci_pull is being called from a module extension in a MODULE.bazel file.
From: https://github.com/bazel-contrib/rules_oci/blob/main/docs/pull.md

 oci = use_extension("@rules_oci//oci:extensions.bzl", "oci")

# A multi-arch base image with variants, note that it won't work with just "linux/arm64"
oci.pull(
    name = "distroless_base_nossl_debian12",
    digest = "sha256:73c3d3f3030516665c916ebc9baa80f89c1a90e438dc02f1fed525ed246c0c2a",
    image = "gcr.io/distroless/base-nossl-debian12",
    platforms = [
        "linux/amd64",
        "linux/arm64/v8",
    ],
)
...
```</div>

Reproduction: https://github.com/renovate-reproductions/31895
@rarkins rarkins added manager:bzlmod Related to the bzlmod manager type:feature Feature (new functionality) priority-4-low Low priority, unlikely to be done unless it becomes important to more people labels Nov 14, 2024
@renovate-release
Copy link
Collaborator

🎉 This issue has been resolved in version 39.50.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
manager:bzlmod Related to the bzlmod manager priority-4-low Low priority, unlikely to be done unless it becomes important to more people type:feature Feature (new functionality)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants