Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(datasource/pypi): always fallback to try simple endpoints #32024

Merged
merged 5 commits into from
Nov 27, 2024

Conversation

rarkins
Copy link
Collaborator

@rarkins rarkins commented Oct 19, 2024

Changes

Modifies pypi datasource so that it always attempts to fall back to a simple result if the JSON API throws an error.

Context

Built on top of #26386 (thanks @Kakadus) and #31771 (thanks @samgiz).

Closes #26483
Closes #26383

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

Closes #26483
Closes #26383

@samgiz
Copy link
Contributor

samgiz commented Oct 29, 2024

Do you need any help from me to get this merged?

@samgiz
Copy link
Contributor

samgiz commented Nov 14, 2024

Is anything stopping this from being merged?

@rarkins rarkins requested a review from viceice November 21, 2024 11:23
Copy link
Contributor

@Kakadus Kakadus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice to see this getting addressed after some time 🎉

Sadly, I were not able to proceed my initial PR as priorities changed and time ran short. Thank you for yours and for renovate!

@rarkins rarkins added this pull request to the merge queue Nov 27, 2024
Merged via the queue into main with commit c868ed0 Nov 27, 2024
39 checks passed
@rarkins rarkins deleted the feat/26483-pypi-always-fallback-simple branch November 27, 2024 09:10
SuperSandro2000 added a commit to SuperSandro2000/renovate that referenced this pull request Nov 27, 2024
* upstream/main: (206 commits)
  build(deps): update dependency @opentelemetry/semantic-conventions to v1.28.0 (renovatebot#32775)
  fix(deps): update ghcr.io/renovatebot/base-image docker tag to v9.11.3 (renovatebot#32774)
  chore(deps): update pnpm to v9.14.2 (renovatebot#32769)
  feat(manager/dockerfile): add support for Dockerfile `RUN --mount=from` (renovatebot#32743)
  feat(datasource/pypi): always fallback to try simple endpoints (renovatebot#32024)
  fix(npm): update npmrc before executing corepack cmd (renovatebot#32733)
  fix(bitbucket): source link root path (renovatebot#32689)
  chore(deps): update docker/dockerfile docker tag to v1.12.0 (renovatebot#32764)
  fix(deps): update ghcr.io/renovatebot/base-image docker tag to v9.11.2 (renovatebot#32763)
  chore(deps): update pnpm to v9.14.1 (renovatebot#32762)
  fix(deps): update ghcr.io/containerbase/sidecar docker tag to v13.0.22 (renovatebot#32761)
  chore(deps): update ghcr.io/containerbase/devcontainer docker tag to v13.0.22 (renovatebot#32759)
  chore(deps): update davidanson/markdownlint-cli2-action action to v18 (renovatebot#32684)
  chore(deps): update containerbase/internal-tools action to v3.5.2 (renovatebot#32757)
  chore(deps): update dependency @types/better-sqlite3 to v7.6.12 (renovatebot#32756)
  test(presets): validate schedule presets (renovatebot#32755)
  ci: disable Windows tests (renovatebot#32754)
  fix(presets): Add F# to dotnet monorepo (renovatebot#32706)
  build(deps): update dependency yaml to v2.6.1 (renovatebot#32744)
  chore(deps): update dependency @types/diff to v6 (renovatebot#32742)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PyPI datasource fall back to simple API if JSON API fails
4 participants