Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(config/presets): correct security-only preset matcher #29801

Merged
merged 1 commit into from
Jun 22, 2024

Conversation

Churro
Copy link
Collaborator

@Churro Churro commented Jun 21, 2024

Changes

The security-only preset currenly includes matchPackageNames: ['*'] which doesn't work because names are not evaluated as patterns. This PR makes it work by using matchPackagePatterns instead.

Unlike matchPackagePatterns (see here), the matchPackageNames matcher (see here) doesn't massage * to .* and doesn't attempt matching names against it. Hence, the security-only preset didn't work so far.

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@rarkins rarkins added this pull request to the merge queue Jun 22, 2024
Merged via the queue into renovatebot:main with commit 5c0b1e1 Jun 22, 2024
37 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.414.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants