Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(datasource/nuget): move v2/v3 API logic to classes #28117

Merged
merged 2 commits into from
Mar 27, 2024

Conversation

fgreinacher
Copy link
Contributor

@fgreinacher fgreinacher commented Mar 25, 2024

Changes

This is a preparation step for being able to use cache decorators more easily

Context

See #28071 (comment)

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

This is a preparation step for being able to use cache decorators more easily
@fgreinacher fgreinacher marked this pull request as ready for review March 25, 2024 10:40
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM

lib/modules/datasource/nuget/v2.ts Outdated Show resolved Hide resolved
@fgreinacher fgreinacher requested a review from viceice March 26, 2024 07:56
@viceice viceice added this pull request to the merge queue Mar 27, 2024
Merged via the queue into renovatebot:main with commit 87bba9d Mar 27, 2024
37 checks passed
@fgreinacher fgreinacher deleted the refactor/nuget-api-classes branch March 27, 2024 11:22
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.273.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

secustor pushed a commit to secustor/renovate that referenced this pull request Mar 31, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants