-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply default rate limits for hosts/registries with known rate limit needs #27802
Comments
If the file is only about rate limits, we could name it: Or do you intend to cover other kinds of limits in the same file? |
We may want to add these hosts/registries to the list:
|
Gradle plugins especially |
With regard to JFrog, it's not clear which host to match, but my guess it's |
The best thing is to find a official answer on the correct rate-limit. If we can't find that info, we could try this:
That gets us close to the correct limit, at the cost of some trial and error. |
Describe the proposed change(s).
For example, the npmjs registry or GOPROXY does not need rate limiting applied, while the following are known to need:
Let's identify all such hosts in a single file/location, in a file like
lib/data/host-limits.ts
. I think we can reusematchHost
syntax, it can maybe even behostRules
format but is not necessary (thematchHost
value can be a key for the Record).Importantly, if a host has a default limit in this file then we should make sure that users cannot increase the rate limit using
hostRules
. Ideally we can catch and warn if such an attempt is made. This protects fragile registries from falling victim to flooding from Renovate users unless they really go out of their way to overcome this.The text was updated successfully, but these errors were encountered: