Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bazel: support use_extension for maven #27601

Closed
rarkins opened this issue Feb 28, 2024 · 5 comments · Fixed by #30884
Closed

Bazel: support use_extension for maven #27601

rarkins opened this issue Feb 28, 2024 · 5 comments · Fixed by #30884
Assignees
Labels
manager:bazel Bazel WORKSPACE files priority-4-low Low priority, unlikely to be done unless it becomes important to more people type:feature Feature (new functionality)

Comments

@rarkins
Copy link
Collaborator

rarkins commented Feb 28, 2024

Describe the proposed change(s).

Requested in #27467

Reproduction can be found in https://github.com/renovate-reproductions/27467/blob/main/MODULE.bazel

@rarkins rarkins added type:feature Feature (new functionality) priority-4-low Low priority, unlikely to be done unless it becomes important to more people manager:bazel Bazel WORKSPACE files labels Feb 28, 2024
@al-babych-fivetran
Copy link
Contributor

Hey! We're interested in working on this feature implementation. Do you have any advice except following the contribution guide and docs/development rules?

@rarkins
Copy link
Collaborator Author

rarkins commented Jul 18, 2024

Nothing specific needed, it can also be easier to have a look at some other recent PRs for examples. Thanks

@kolloch
Copy link

kolloch commented Jul 26, 2024

Potentially interesting to support MODULE.bazel includes:

https://bazel.build/rules/lib/globals/module#include

Example:

https://github.com/kolloch/bazel_kotlin/blob/85dd66da2eea57266cf7a91e54b4ca50fc34ba38/MODULE.bazel#L19

It might also be fine to glob for all *.MODULE.bazel files in the repo.

@kolloch
Copy link

kolloch commented Jul 26, 2024

Probably too difficult to support but would be a nice feature would be version numbers that are factored out to variables, e.g.:

https://github.com/kolloch/bazel_kotlin/blob/85dd66da2eea57266cf7a91e54b4ca50fc34ba38/MODULE.bazel#L64-L95

@renovate-release
Copy link
Collaborator

🎉 This issue has been resolved in version 38.49.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
manager:bazel Bazel WORKSPACE files priority-4-low Low priority, unlikely to be done unless it becomes important to more people type:feature Feature (new functionality)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants