Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save repo cache even if dry run #27034

Open
rarkins opened this issue Feb 3, 2024 · 3 comments
Open

Save repo cache even if dry run #27034

rarkins opened this issue Feb 3, 2024 · 3 comments
Labels
core:cache priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others

Comments

@rarkins
Copy link
Collaborator

rarkins commented Feb 3, 2024

Describe the proposed change(s).

If we run with dryRun=lookup on a repo two times in a row, and repositoryCache=enabled, then we should still save and reuse the cache.

@rarkins rarkins added priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others core:cache labels Feb 3, 2024
@viceice
Copy link
Member

viceice commented Feb 3, 2024

but not on full dry run, otherwise branch and PR data gets out of sync.

@rarkins
Copy link
Collaborator Author

rarkins commented Feb 3, 2024

Excluding branch state then? I'm after extract and config cache so that lookup dry runs don't always clone/fetch PRs, etc

@viceice
Copy link
Member

viceice commented Feb 3, 2024

🤔 depends. are you planning to allow to share the cache between dry run and non dry run? I think we can't do it because it always causes inconsistencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core:cache priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others
Projects
None yet
Development

No branches or pull requests

3 participants
@viceice @rarkins and others