Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up repo http cache after each run #27032

Open
rarkins opened this issue Feb 3, 2024 · 0 comments
Open

Clean up repo http cache after each run #27032

rarkins opened this issue Feb 3, 2024 · 0 comments
Labels
core:cache priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others

Comments

@rarkins
Copy link
Collaborator

rarkins commented Feb 3, 2024

Describe the proposed change(s).

Currently there is no cleanup at all, which could mean that we have a growing cache of stale http responses in case we change what we cache, have a bug, etc.

We should have a way of cleaning up stale http responses somehow, either using dates, or some other intelligent manner. Note: it's possible that we don't use a http cache every run, for example if the default SHA of a repo is unchanged then we don't need to check the config file contents again. In such a case we don't want to discard the cached etag/response.

@rarkins rarkins added priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others core:cache labels Feb 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core:cache priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others
Projects
None yet
Development

No branches or pull requests

2 participants
@rarkins and others