Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(manager): move some logic from gitlabci-include to gitlabci manager #26722

Merged
merged 2 commits into from
Jan 18, 2024

Conversation

fgreinacher
Copy link
Contributor

@fgreinacher fgreinacher commented Jan 18, 2024

Changes

Moving some logic as preparation for #26660

Context

#23431

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

⚒️ with ❤️ by Siemens

@fgreinacher fgreinacher marked this pull request as ready for review January 18, 2024 08:43
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM

lib/modules/manager/gitlabci/__fixtures__/include.2.yaml Outdated Show resolved Hide resolved
@viceice viceice enabled auto-merge January 18, 2024 19:02
@viceice viceice added this pull request to the merge queue Jan 18, 2024
Merged via the queue into renovatebot:main with commit 6256983 Jan 18, 2024
36 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.140.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

zT-1337 pushed a commit to scm-manager/renovate that referenced this pull request Jan 22, 2024
zT-1337 pushed a commit to scm-manager/renovate that referenced this pull request Jan 24, 2024
zT-1337 pushed a commit to scm-manager/renovate that referenced this pull request Jan 24, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 18, 2024
@fgreinacher fgreinacher deleted the refactor/gitlabci-move branch April 5, 2024 08:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants