-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(nuget): gracefully accept a lack of a PackageBaseAddress resource #25355
Merged
viceice
merged 11 commits into
renovatebot:main
from
dhduvall:duvall/nuget-nopagekbaseaddress
Oct 26, 2023
Merged
fix(nuget): gracefully accept a lack of a PackageBaseAddress resource #25355
viceice
merged 11 commits into
renovatebot:main
from
dhduvall:duvall/nuget-nopagekbaseaddress
Oct 26, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhduvall
commented
Oct 23, 2023
zharinov
approved these changes
Oct 24, 2023
viceice
reviewed
Oct 24, 2023
lib/modules/datasource/nuget/__fixtures__/v3_index_no_packagebaseaddress.json
Outdated
Show resolved
Hide resolved
auto-merge was automatically disabled
October 24, 2023 16:54
Head branch was pushed to by a user without write access
viceice
reviewed
Oct 25, 2023
HonkingGoose
suggested changes
Oct 25, 2023
dhduvall
changed the title
fix(nuget): gracefuly accept a lack of a PackageBaseAddress resource
fix(nuget): gracefully accept a lack of a PackageBaseAddress resource
Oct 25, 2023
viceice
reviewed
Oct 26, 2023
viceice
approved these changes
Oct 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks
🎉 This PR is included in version 37.33.6 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
jon4hz
pushed a commit
to jon4hz/renovate
that referenced
this pull request
Nov 9, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
"Fixes" a
TypeError
when finding releases of NuGet packages on GitLab.Context
As documented in https://gitlab.com/gitlab-org/gitlab/-/issues/325835, the GitLab NuGet API is missing the
PackageBaseAddress
service. This results in aTypeError
when deconstructing the first of the matching services (this is grabbed from the test output, which is why that first line is a little weird):Although the exception is caught and
renovate
continues, the error in the log is surprising and not especially helpful, so I'm preempting the exception with a custom one with a clearer message. There's still nothing that can be done about it, but anyone seeing it in the logs shouldn't be as confused.Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: