fix: add httpsCertificate, httpsPrivateKey and httpsCertificateAuthority into redactedFields #25013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ity into redactedFields
rarkins
approved these changes
Oct 4, 2023
|
🎉 This PR is included in version 37.5.3 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
|
isn't the private key the only sensitive data? 🤔 |
cdloh
added a commit
to cdloh/renovate
that referenced
this pull request
Oct 5, 2023
… into feat/add-ubuntu-container-support * fork/feat/add-ubuntu-container-support: fix(npm): re-enable lock file maintenance (renovatebot#25045) chore: drop `status:ready` and improve triage docs (renovatebot#25023) fix(go): Ignore `mod` type of `go-import` header (renovatebot#25039) chore(deps): update dependency @types/moo to v0.5.7 (renovatebot#25031) feat(terraform-module): always use 'source' as sourceUrl when available (renovatebot#25008) chore(deps): update dependency @types/mdast to v3.0.13 (renovatebot#25027) build(deps): update dependency @types/ms to v0.7.32 (renovatebot#25026) chore: drop `priority-5-triage` label (renovatebot#25024) chore(lookup): include package name in warning message (renovatebot#24998) chore: allow null value and undefined for validateURL (renovatebot#25014) fix: add httpsCertificate, httpsPrivateKey and httpsCertificateAuthority into redactedFields (renovatebot#25013) chore(deps): update dependency type-fest to v4.3.3 (renovatebot#25011) chore(deps): update dependency @types/markdown-it to v13.0.2 (renovatebot#25010) build(deps): update dependency zod to v3.22.3 [security] (renovatebot#25007) chore(deps): update dependency type-fest to v4.3.2 (renovatebot#25006) build(deps): update dependency markdown-it to v13.0.2 (renovatebot#25005)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
add
httpsCertificate,httpsPrivateKeyandhttpsCertificateAuthorityinto redactedFields so that they don't show up in the loggerContext
When using the https options to hostRules on developing on the discussion of moving setGlobalHostRules before platform initialisation, I realised that those sensitive options might appears in the log as clear text (e.g. when log level = trace). Hence adding those fields to redactedFields. here is an example output
{ "hostType": "github", "matchHost": "some.ghe.host", "httpsCertificate": "***********", "httpsCertificateAuthority": "***********", "httpsPrivateKey": "***********" },Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: