Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kustomize): validate name is a string #24676

Merged
merged 3 commits into from
Sep 27, 2023
Merged

Conversation

rarkins
Copy link
Collaborator

@rarkins rarkins commented Sep 26, 2023

Changes

Validate that image name is a string before parsing.

Context

Closes #20055

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@rarkins rarkins requested a review from viceice September 26, 2023 14:26
viceice
viceice previously approved these changes Sep 26, 2023
@rarkins rarkins requested a review from viceice September 26, 2023 20:09
@viceice viceice added this pull request to the merge queue Sep 27, 2023
Merged via the queue into main with commit a6c9075 Sep 27, 2023
@viceice viceice deleted the fix/20055-kustomize-name-string branch September 27, 2023 08:44
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 36.109.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: cleanedCurrentFrom?.includes is not a function
3 participants