Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(migrate): regexManagers -> customManagers #24451

Merged
merged 16 commits into from
Sep 24, 2023
Merged

feat(migrate): regexManagers -> customManagers #24451

merged 16 commits into from
Sep 24, 2023

Conversation

RahulGautamSingh
Copy link
Collaborator

@RahulGautamSingh RahulGautamSingh commented Sep 16, 2023 •
edited
Loading

Changes

  • Add regexManagers to the MigrationServices.renamedProperties array
  • Convert regex-managers-migration.ts to custom-managers-migration.ts and target customMangers key instead of regexManagers
  • Change regexManagers -> customManagers in the code and in docs where necessary

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@RahulGautamSingh
Copy link
Collaborator Author

RahulGautamSingh commented Sep 16, 2023 •
edited
Loading

Test-run: RahulGautamSingh-testing/r-m#4

I checked the following in the above test-run

  1. regexManager is renamed to customManagers
  2. customType is added to customManagers if not present
  3. customManager is working

@RahulGautamSingh RahulGautamSingh changed the title feat(migrate): regexManagers -> customManagers feat(migrate): regexManagers -> customManagers [WIP] Sep 16, 2023
@RahulGautamSingh
Copy link
Collaborator Author

RahulGautamSingh commented Sep 16, 2023 •
edited
Loading

Work remaining: Update docs

@RahulGautamSingh RahulGautamSingh marked this pull request as draft September 16, 2023 02:24
@RahulGautamSingh RahulGautamSingh mentioned this pull request Sep 16, 2023
Closed
@RahulGautamSingh RahulGautamSingh marked this pull request as ready for review September 19, 2023 01:38
@RahulGautamSingh RahulGautamSingh changed the title feat(migrate): regexManagers -> customManagers [WIP] feat(migrate): regexManagers -> customManagers Sep 19, 2023
rarkins
rarkins previously approved these changes Sep 20, 2023
View reviewed changes
Copy link
Collaborator

@rarkins rarkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope it works

@HonkingGoose HonkingGoose mentioned this pull request Sep 20, 2023
Closed
HonkingGoose
HonkingGoose suggested changes Sep 20, 2023
View reviewed changes
docs/usage/user-stories/swissquote.md Outdated Show resolved Hide resolved
lib/config/migrations/custom/custom-managers-migration.ts Outdated Show resolved Hide resolved
lib/config/validation.spec.ts Show resolved Hide resolved
lib/config/validation.ts Show resolved Hide resolved
docs/usage/configuration-options.md Outdated Show resolved Hide resolved
docs/usage/configuration-options.md Outdated Show resolved Hide resolved
docs/usage/configuration-options.md Outdated Show resolved Hide resolved
docs/usage/configuration-options.md Outdated Show resolved Hide resolved
docs/usage/configuration-options.md Outdated Show resolved Hide resolved
docs/usage/configuration-options.md Outdated Show resolved Hide resolved
@rarkins rarkins requested a review from secustor September 22, 2023 04:21
secustor
secustor reviewed Sep 22, 2023
View reviewed changes
docs/usage/configuration-options.md Outdated Show resolved Hide resolved
docs/usage/configuration-options.md Outdated Show resolved Hide resolved
docs/usage/configuration-options.md Outdated Show resolved Hide resolved
lib/modules/manager/custom/regex/readme.md Outdated Show resolved Hide resolved
secustor
secustor previously approved these changes Sep 22, 2023
View reviewed changes
@rarkins rarkins added this pull request to the merge queue Sep 24, 2023
Merged via the queue into renovatebot:main with commit 6f9d37a Sep 24, 2023
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 36.107.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@secustor secustor secustor approved these changes

@viceice viceice Awaiting requested review from viceice

@HonkingGoose HonkingGoose Awaiting requested review from HonkingGoose

@rarkins rarkins Awaiting requested review from rarkins

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@RahulGautamSingh @renovate-release @rarkins @secustor @HonkingGoose