-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(manager/helmv3): add support for ECR credentials #24432
Merged
rarkins
merged 7 commits into
renovatebot:main
from
ezzatron:feat/19241-helm-ecr-credentials
Sep 23, 2023
Merged
feat(manager/helmv3): add support for ECR credentials #24432
rarkins
merged 7 commits into
renovatebot:main
from
ezzatron:feat/19241-helm-ecr-credentials
Sep 23, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viceice
reviewed
Sep 15, 2023
viceice
changed the title
feat(manager/helmv3): add support for ECR credentials (#19241)
feat(manager/helmv3): add support for ECR credentials
Sep 15, 2023
ezzatron
commented
Sep 15, 2023
secustor
requested changes
Sep 15, 2023
secustor
approved these changes
Sep 22, 2023
rarkins
approved these changes
Sep 23, 2023
🎉 This PR is included in version 36.104.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR allows Renovate to use
helm registry login
to sign in with an AWS ECR token when updating Helm dependencies.Context
Addresses the discussion in #19241.
Prior to this change, Helm library chart updates from AWS ECR could be detected by Renovate so long as AWS credentials were configured in
hostRules
, but when attempting to runhelm dependency update
, the update would always fail, because Helm itself was not signed in to the registry. This PR re-uses some code from thedocker
manager for acquiring an ECR token, and uses the token to sign in to the registry.We have Helm library charts in an AWS ECR registry at my workplace, and I have run this code against one of our repos which was previously failing with an error like:
After these changes, the Renovate PR was successfully created.
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: