Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(types): move custom manager types #24324

Merged
merged 9 commits into from
Sep 13, 2023
Merged

refactor(types): move custom manager types #24324

merged 9 commits into from
Sep 13, 2023

Conversation

RahulGautamSingh
Copy link
Collaborator

@RahulGautamSingh RahulGautamSingh commented Sep 8, 2023 •
edited
Loading

distribute types CustomManager and RegexManager

Changes

  • Moved custom manager types inside the manager/custom folder so that it is easy to find and refactor them since they are clser to their sources.
  • Updating interfaces CustomManager and CustomExtractConfig to extends custom manager configs

Context

Part of: #19066

  • Make changes to CustomManager types to simplify adding new custom manager defns to it

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@RahulGautamSingh
move custom manager types to /custom
fb8ebc9 
distribute types CustomManager and RegexManager
viceice
viceice reviewed Sep 8, 2023
View reviewed changes
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM

lib/modules/manager/custom/regex/strategies.ts Outdated Show resolved Hide resolved
@rarkins rarkins added this pull request to the merge queue Sep 13, 2023
Merged via the queue into renovatebot:main with commit 2ffbd41 Sep 13, 2023
34 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 36.93.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rarkins rarkins rarkins approved these changes

@viceice viceice Awaiting requested review from viceice

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RahulGautamSingh @renovate-release @viceice @rarkins