Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(versioning): Add schema transform #23047

Merged
merged 8 commits into from
Jul 1, 2023
Merged

feat(versioning): Add schema transform #23047

merged 8 commits into from
Jul 1, 2023

Conversation

zharinov
Copy link
Collaborator

@zharinov zharinov commented Jun 29, 2023 •
edited
Loading

Changes

For refactoring purposes, it's useful to have dedicated schema for versioning field that is automatically transformed from string to the according VersioningApi instance.

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@zharinov zharinov marked this pull request as draft June 29, 2023 14:10
viceice
viceice reviewed Jun 29, 2023
View reviewed changes
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's the benefit here? 🤔

@zharinov
Copy link
Collaborator Author

Planning to use it in further refactoring PRs

@zharinov zharinov marked this pull request as ready for review June 29, 2023 19:04
@zharinov zharinov requested review from rarkins and viceice June 29, 2023 19:55
@rarkins rarkins added this pull request to the merge queue Jul 1, 2023
Merged via the queue into renovatebot:main with commit 6a2564d Jul 1, 2023
@rarkins rarkins deleted the feat/versioning-schema-transform branch July 1, 2023 06:54
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 35.152.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot mentioned this pull request Jul 9, 2023
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@viceice viceice viceice approved these changes

@rarkins rarkins Awaiting requested review from rarkins

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zharinov @renovate-release @viceice @rarkins