Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(datasource)!: default to the central default versioning #23020

Merged
merged 5 commits into from
Jun 29, 2023
Merged

feat(datasource)!: default to the central default versioning #23020

merged 5 commits into from
Jun 29, 2023

Conversation

secustor
Copy link
Collaborator

Changes

Use the default versioning defined in versioning/index if no defaultVersioning is defined in datasources

Context

#22957 (reply in thread)

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@secustor secustor added the breaking Breaking change, requires major version bump label Jun 28, 2023
@secustor secustor force-pushed the feat/default_to_semver-coercerd branch from 032b461 to fda51fc Compare June 28, 2023 13:39
rarkins
rarkins previously approved these changes Jun 28, 2023
View reviewed changes
@secustor secustor marked this pull request as ready for review June 29, 2023 06:23
@secustor secustor requested a review from rarkins June 29, 2023 06:23
viceice
viceice previously approved these changes Jun 29, 2023
View reviewed changes
@secustor secustor requested a review from viceice June 29, 2023 08:08
@rarkins rarkins enabled auto-merge (squash) June 29, 2023 08:37
@rarkins rarkins merged commit caa425c into renovatebot:v36 Jun 29, 2023
@secustor secustor deleted the feat/default_to_semver-coercerd branch June 29, 2023 08:39
rarkins pushed a commit that referenced this pull request Jul 1, 2023
@secustor @rarkins
feat(datasource)!: default to the central default versioning (#23020)
061c0f4
rarkins pushed a commit that referenced this pull request Jul 4, 2023
@secustor @rarkins
feat(datasource)!: default to the central default versioning (#23020)
6d2c783
rarkins pushed a commit that referenced this pull request Jul 4, 2023
@secustor @rarkins
feat(datasource)!: default to the central default versioning (#23020)
db728be
rarkins pushed a commit that referenced this pull request Jul 4, 2023
@secustor @rarkins
feat(datasource)!: default to the central default versioning (#23020)
43419c5 
BREAKING CHANGE: semver-coerced is now the default versioning
rarkins pushed a commit that referenced this pull request Jul 4, 2023
@secustor @rarkins
feat(datasource)!: default to the central default versioning (#23020)
5df0e29 
BREAKING CHANGE: semver-coerced is now the default versioning
rarkins pushed a commit that referenced this pull request Jul 4, 2023
@secustor @rarkins
feat(datasource)!: default to the central default versioning (#23020)
8ccb0ea 
BREAKING CHANGE: semver-coerced is now the default versioning
@github-actions github-actions bot mentioned this pull request Jul 9, 2023
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rarkins rarkins rarkins approved these changes

@viceice viceice Awaiting requested review from viceice

Assignees
No one assigned
Labels
breaking Breaking change, requires major version bump
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@secustor @viceice @rarkins