Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: drop node v19 support #23006

Merged
merged 1 commit into from
Jul 1, 2023
Merged

feat!: drop node v19 support #23006

merged 1 commit into from
Jul 1, 2023

Conversation

rarkins
Copy link
Collaborator

@rarkins rarkins commented Jun 27, 2023

Changes

Drops Node v19 support

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@rarkins rarkins requested a review from viceice June 27, 2023 12:25
@rarkins rarkins added the breaking Breaking change, requires major version bump label Jun 27, 2023
@rarkins rarkins changed the title feat!: allow post upgrade templating by default (#21326) feat!: drop node v19 support Jun 27, 2023
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

conflicted

@rarkins rarkins merged commit 14ccb9a into v36 Jul 1, 2023
@rarkins rarkins deleted the feat/drop-node-19 branch July 1, 2023 08:08
rarkins added a commit that referenced this pull request Jul 4, 2023
rarkins added a commit that referenced this pull request Jul 4, 2023
rarkins added a commit that referenced this pull request Jul 4, 2023
BREAKING CHANGE: Node v19 is no longer supported
rarkins added a commit that referenced this pull request Jul 4, 2023
BREAKING CHANGE: Node v19 is no longer supported
rarkins added a commit that referenced this pull request Jul 4, 2023
BREAKING CHANGE: Node v19 is no longer supported
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
breaking Breaking change, requires major version bump
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants