-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(platform/bitbucket): support reopening declined PRs via comments #22984
feat(platform/bitbucket): support reopening declined PRs via comments #22984
Conversation
Demonstration repository: https://bitbucket.org/setchy87/demo-repo |
Here's another idea - what about having the option to consider all users authorized if a repo is private? In such case you can pretty safely assume that someone who adds a comment to a PR is allowed to do so. It's only public repos where we want to avoid nuisance/spam |
Let me recap to ensure I understand your thoughts "is_private":true - Private Repository
"is_private":false - Public Repository
|
Any preference on (a) or (b) @rarkins. Looks like we can reuse the |
I've implemented (b) for public repositories - changes pushed 😄 |
🎉 This PR is included in version 35.158.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Changes
Adds Bitbucket Cloud specific handling for reopening declined PRs (system limitation prevents these being renamed or reopened)
Will look for any comments starting with
reopen!
on the declined PR.Additionally, if the repository is also public, it will check that the commenter is a member of the Bitbucket workspace members
Context
Closes #14243
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: