Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(manager/gradle): extend allowed nesting depth for Kotlin objects from 3 to 4 #22959

Merged
merged 1 commit into from
Jun 24, 2023

Conversation

Churro
Copy link
Collaborator

@Churro Churro commented Jun 24, 2023

Changes

Adds an additional nesting depth layer to the gradle parser for Kotlin objects.

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

Test repo: https://github.com/renovate-demo/22948-renovate-gradle-issue/pull/2

@rarkins rarkins added this pull request to the merge queue Jun 24, 2023
Merged via the queue into renovatebot:main with commit edb9518 Jun 24, 2023
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 35.141.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@@ -49,6 +49,8 @@ const qKotlinMultiObjectExpr = (

export const qKotlinMultiObjectVarAssignment = qKotlinMultiObjectExpr(
qKotlinMultiObjectExpr(
qKotlinMultiObjectExpr(qKotlinSingleObjectVarAssignment)
qKotlinMultiObjectExpr(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

max nesting should probably documented on manager readme

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants