Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(go): Change iteration over major versions #22900

Merged
merged 7 commits into from
Jun 21, 2023
Merged

refactor(go): Change iteration over major versions #22900

merged 7 commits into from
Jun 21, 2023

Conversation

zharinov
Copy link
Collaborator

@zharinov zharinov commented Jun 20, 2023 •
edited
Loading

Changes

  • Change iteration in a way that is easier for processing @latest endpoint

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@zharinov zharinov marked this pull request as draft June 20, 2023 19:22
@zharinov zharinov marked this pull request as ready for review June 20, 2023 19:22
@zharinov zharinov requested review from rarkins and viceice June 20, 2023 19:22
viceice
viceice previously approved these changes Jun 20, 2023
View reviewed changes
lib/modules/datasource/go/releases-goproxy.ts Show resolved Hide resolved
viceice
viceice approved these changes Jun 20, 2023
View reviewed changes
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤞🤷‍♂️

@rarkins rarkins added this pull request to the merge queue Jun 21, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 21, 2023
@zharinov zharinov marked this pull request as draft June 21, 2023 08:37
@zharinov zharinov marked this pull request as ready for review June 21, 2023 08:37
@zharinov zharinov mentioned this pull request Jun 21, 2023
Merged
6 tasks
@rarkins rarkins added this pull request to the merge queue Jun 21, 2023
Merged via the queue into renovatebot:main with commit 192fe84 Jun 21, 2023
@rarkins rarkins deleted the refactor/goproxy-query-versions branch June 21, 2023 09:38
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 35.138.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot mentioned this pull request Jul 9, 2023
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@viceice viceice viceice approved these changes

@rarkins rarkins Awaiting requested review from rarkins

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zharinov @renovate-release @viceice @rarkins