Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support relative paths for config presets #17561

Closed
remal opened this issue Aug 31, 2022 · 5 comments
Closed

Support relative paths for config presets #17561

remal opened this issue Aug 31, 2022 · 5 comments

Comments

@remal
Copy link

remal commented Aug 31, 2022

What would you like Renovate to be able to do?

We have several repositories that have the same files automatically synchronized between them. Renovate's config is one of them.

It would be cool if we could use relative paths in shared config presets. It would allow us to use synchronized base Renovate config and included repository specific preset.

If you have any ideas on how this should be implemented, please tell us here.

If extends section has a value starting with ./ or ../, it should be treated as a relative path and loaded accordingly.

Is this a feature you are interested in implementing yourself?

Maybe

@remal remal added priority-5-triage status:requirements Full requirements are not yet known, so implementation should not be started type:feature Feature (new functionality) labels Aug 31, 2022
@rarkins
Copy link
Collaborator

rarkins commented Sep 2, 2022

What would the syntax look like?

@remal
Copy link
Author

remal commented Sep 6, 2022

@rarkins If extends section has a value starting with ./ or ../, it should be treated as a relative path to the current config file.

However, I'm not sure how nested extends works (when an included file includes another file), there can be some difficulties here.

@viceice
Copy link
Member

viceice commented Sep 6, 2022

the main difficulty is that preset does know anything about paths at all, that info is only available on platform code, bit that doesn't know anything about parent preset.

@remal
Copy link
Author

remal commented Sep 7, 2022

We can live without this feature (with some hacks), but we'd appreciate it if Renovate teams implemented it. However, I understand that it may take a lot of time to implement, and not many users need this feature, so it's not a high priority.

@rarkins rarkins added priority-4-low Low priority, unlikely to be done unless it becomes important to more people core:config Related to config capabilities and presets auto:reproduction A minimal reproduction is necessary to proceed and removed priority-5-triage labels Sep 7, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2022

Hi there,

Get your issue fixed faster by creating a minimal reproduction. This means a repository dedicated to reproducing this issue with the minimal dependencies and config possible.

Before we start working on your issue we need to know exactly what's causing the current behavior. A minimal reproduction helps us with this.

To get started, please read our guide on creating a minimal reproduction.

We may close the issue if you, or someone else, haven't created a minimal reproduction within two weeks. If you need more time, or are stuck, please ask for help or more time in a comment.

Good luck,

The Renovate team

@rarkins rarkins removed type:feature Feature (new functionality) priority-4-low Low priority, unlikely to be done unless it becomes important to more people auto:reproduction A minimal reproduction is necessary to proceed status:requirements Full requirements are not yet known, so implementation should not be started core:config Related to config capabilities and presets labels Oct 1, 2023
@renovatebot renovatebot locked and limited conversation to collaborators Oct 1, 2023
@rarkins rarkins converted this issue into discussion #24753 Oct 1, 2023

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants