Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bitbucket Cloud: include Release Notes in Renovate PRs #14964

Closed
Tracked by #14138
einarpehrson opened this issue Apr 5, 2022 · 9 comments · Fixed by #22094
Closed
Tracked by #14138

Bitbucket Cloud: include Release Notes in Renovate PRs #14964

einarpehrson opened this issue Apr 5, 2022 · 9 comments · Fixed by #22094
Assignees
Labels
auto:reproduction A minimal reproduction is necessary to proceed core:changelogs Related to changelogs/release notes fetching platform:bitbucket Bitbucket Cloud platform priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others status:blocked Issue is blocked by another issue or external requirement type:feature Feature (new functionality)

Comments

@einarpehrson
Copy link

What would you like Renovate to be able to do?

For libraries hosted on Bitbucket Cloud, populate the Release Notes section in Renovate PRs.

If you have any ideas on how this should be implemented, please tell us here.

Is this a feature you are interested in implementing yourself?

No

@einarpehrson einarpehrson added priority-5-triage status:requirements Full requirements are not yet known, so implementation should not be started type:feature Feature (new functionality) labels Apr 5, 2022
@HonkingGoose HonkingGoose added the core:changelogs Related to changelogs/release notes fetching label Apr 5, 2022
@HonkingGoose
Copy link
Collaborator

I don't see release note fetching listed in the list of unsupported platform features for BitBucket Cloud, so I guess it should work if set up correctly.

Did you create a GitHub.com token to fetch the release notes? Read the GitHub.com token for release notes page in our docs.

This issue also discusses release note fetching on BitBucket Cloud:

@HonkingGoose HonkingGoose added the platform:bitbucket Bitbucket Cloud platform label Apr 5, 2022
@einarpehrson
Copy link
Author

@HonkingGoose thanks for having a look at this so quickly :)

As you say, Bitbucket Cloud: Unsupported platform features/concepts doesn't mention it, nor does Renovate core features not supported on all platforms.

But the code for the changelog worker suggests that only GitHub and GitLab are supported. I can't find any implementation for other platforms.

A GitHub token shouldn't be needed here. For scenarios where a repository hosted on Bitbucket Cloud receives a Renovate PR with an upgrade for a dependency also hosted on Bitbucket Cloud, GitHub is not involved in any way.

@viceice
Copy link
Member

viceice commented Apr 5, 2022

@HonkingGoose HonkingGoose added status:blocked Issue is blocked by another issue or external requirement priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others and removed status:requirements Full requirements are not yet known, so implementation should not be started priority-5-triage labels Apr 5, 2022
@HonkingGoose
Copy link
Collaborator

@HonkingGoose thanks for having a look at this so quickly :)

Cheers! 😄

As you say, Bitbucket Cloud: Unsupported platform features/concepts doesn't mention it, nor does Renovate core features not supported on all platforms.

But the code for the changelog worker suggests that only GitHub and GitLab are supported. I can't find any implementation for other platforms.

@einarpehrson You're right, it looks like we don't support fetching release notes on Bitbucket Cloud at all. You should be able to find out by reading the docs though, instead of needing to go search in the code. I created a issue to improve the docs, see: #14971. 😉

A GitHub token shouldn't be needed here. For scenarios where a repository hosted on Bitbucket Cloud receives a Renovate PR with an upgrade for a dependency also hosted on Bitbucket Cloud, GitHub is not involved in any way.

Our docs still recommend that you add a GitHub.com token anyway 1. I guess if you're fully on Bitbucket with both the bot and your dependencies that Renovate won't need a GitHub.com token, but you might still have dependencies with changelogs from GitHub without realizing it. I'll let @rarkins check me on this. 😉

Footnotes

  1. https://docs.renovatebot.com/getting-started/running/#githubcom-token-for-release-notes

@rarkins rarkins added the auto:reproduction A minimal reproduction is necessary to proceed label Apr 5, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Apr 5, 2022

Hi there,

Help us by making a minimal reproduction repository.

Before we can start work on your issue we first need to know exactly what's causing the current behavior. A minimal reproduction helps us with this.

To get started, please read our guide on creating a minimal reproduction to understand what is needed.

We may close the issue if you (or someone else) have not provided a minimal reproduction within two weeks. If you need more time, or are stuck, please ask for help or more time in a comment.

Good luck,

The Renovate team

@setchy
Copy link
Collaborator

setchy commented May 1, 2023

@rarkins @viceice - this topic came up at my org today.

We'd be interest in leaning-in add contributing support for fetching changelogs from platform:bitbucket.

Would that be of interested?

Question for you both: how important is the resolving #14138 in order to progress the bitbucket support in the near-term?

@rarkins
Copy link
Collaborator

rarkins commented May 2, 2023

I'm ok with you adding it prior. I think #14138 may take a very long time to get done

@viceice
Copy link
Member

viceice commented May 3, 2023

@setchy If you start implementing it please try to make the new code as reusable as possible, so the we improve exiting stuff easier. 🤗

@renovate-release
Copy link
Collaborator

🎉 This issue has been resolved in version 35.159.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
auto:reproduction A minimal reproduction is necessary to proceed core:changelogs Related to changelogs/release notes fetching platform:bitbucket Bitbucket Cloud platform priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others status:blocked Issue is blocked by another issue or external requirement type:feature Feature (new functionality)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants