Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ansible-galaxy datasource : enable the customRegistrySupport #14799

Closed
lutin-malin opened this issue Mar 25, 2022 · 9 comments · Fixed by #25675
Closed

Ansible-galaxy datasource : enable the customRegistrySupport #14799

lutin-malin opened this issue Mar 25, 2022 · 9 comments · Fixed by #25675
Labels
priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others type:feature Feature (new functionality)

Comments

@lutin-malin
Copy link

How are you running Renovate?

Self-hosted

If you're self-hosting Renovate, tell us what version of Renovate you run.

32.6.12

Please select which platform you are using if self-hosting.

Bitbucket Server

If you're self-hosting Renovate, tell us what version of the platform you run.

N/A

Was this something which used to work for you, and then stopped?

I never saw this working

Describe the bug

According the the galaxy documentation, a declared collection can specify its own source.

[My] use case : a self hosted galaxy server hosting private collections.

here could be an example :

#requirements.yml
---
collections:
  - name: awx.awx
    version: 19.0.0
    source: [my internal galaxy server]

At runtime, the specified source is ignored, and fallback to hardcoded value 'https://galaxy.ansible.com/'
https://github.com/renovatebot/renovate/blob/main/lib/modules/datasource/galaxy-collection/index.ts#L22

which leads to unretreived version values.

Relevant debug logs

Logs
 WARN: Custom registries are not allowed for this datasource and will be ignored (repository=[my repo])

Have you created a minimal reproduction repository?

No reproduction repository

@lutin-malin lutin-malin added priority-5-triage status:requirements Full requirements are not yet known, so implementation should not be started type:bug Bug fix of existing functionality labels Mar 25, 2022
@rarkins
Copy link
Collaborator

rarkins commented Mar 25, 2022

So are the custom sources extracted correctly by the manager but then ignored by the datasource?

@lutin-malin
Copy link
Author

So are the custom sources extracted correctly by the manager but then ignored by the datasource?

yes, out of the shelf !

@rarkins
Copy link
Collaborator

rarkins commented Mar 25, 2022

In that case this might work if we just set the custom registry flag from false to true

@lutin-malin
Copy link
Author

that's what i did locally, and it is working 'almost' well.

Remains a typo with the registry url for which the trailing backslash is removed( ... )

@rarkins rarkins added type:feature Feature (new functionality) priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others auto:reproduction A minimal reproduction is necessary to proceed and removed type:bug Bug fix of existing functionality priority-5-triage labels Mar 28, 2022
@github-actions

This comment was marked as resolved.

@lutin-malin
Copy link
Author

lutin-malin commented Mar 29, 2022

minimalistic reproduction repository:
https://github.com/lutin-malin/renovate-reproduction-14799

@rarkins rarkins added status:ready and removed auto:reproduction A minimal reproduction is necessary to proceed status:requirements Full requirements are not yet known, so implementation should not be started labels Apr 11, 2022
@TheLastProject
Copy link

Am I correct in understanding this issue also affect git clones? We seem to be suffering from something similar:

{"name":"renovate","hostname":"<removed>","pid":8,"level":40,"logContext":"<removed>","repository":"<removed>","datasource":"git-tags","registryUrls":["git@gitlab.<removed>:<removed>/mirrors/ansible-collections/community.docker"],"defaultRegistryUrls":null,"msg":"Custom registries are not allowed for this datasource and will be ignored","time":"2023-04-18T08:53:54.136Z","v":0}

With the following requirements.yml:

collections:
  - name: community.docker
    source: git@gitlab.<removed>:<removed>/mirrors/ansible-collections/community.docker
    type: git
    version: 2.7.5

@viceice
Copy link
Member

viceice commented Apr 18, 2023

Am I correct in understanding this issue also affect git clones? We seem to be suffering from something similar:

{"name":"renovate","hostname":"<removed>","pid":8,"level":40,"logContext":"<removed>","repository":"<removed>","datasource":"git-tags","registryUrls":["git@gitlab.<removed>:<removed>/mirrors/ansible-collections/community.docker"],"defaultRegistryUrls":null,"msg":"Custom registries are not allowed for this datasource and will be ignored","time":"2023-04-18T08:53:54.136Z","v":0}

With the following requirements.yml:

collections:
  - name: community.docker
    source: git@gitlab.<removed>:<removed>/mirrors/ansible-collections/community.docker
    type: git
    version: 2.7.5

no, that's a different issue on the manager. please open a new discussion for that

@renovate-release
Copy link
Collaborator

🎉 This issue has been resolved in version 37.69.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others type:feature Feature (new functionality)
Projects
None yet
5 participants