Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support scan buildSrc's Dependencies? #13295

Closed
logosmjt opened this issue Dec 28, 2021 · 7 comments · Fixed by #21892
Closed

Support scan buildSrc's Dependencies? #13295

logosmjt opened this issue Dec 28, 2021 · 7 comments · Fixed by #21892
Assignees
Labels
manager:gradle Gradle package manager priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others type:feature Feature (new functionality)

Comments

@logosmjt
Copy link

logosmjt commented Dec 28, 2021

What would you like Renovate to be able to do?

buildSrc     
├── src    
│ └── main   
│ ─└── kotlin   
│ ──└── Dependencies.kt   
├── build.gradle.kts

There are many projects that manage dependencies in this way.
Renovate could support this way to scan?

If you have any ideas on how this should be implemented, please tell us here.

Scan Dependencies.kt and build.gradle.kts.

Is this a feature you are interested in implementing yourself?

Maybe

@logosmjt logosmjt added priority-5-triage status:requirements Full requirements are not yet known, so implementation should not be started type:feature Feature (new functionality) labels Dec 28, 2021
@rarkins rarkins added manager:gradle Gradle package manager auto:reproduction A minimal reproduction is necessary to proceed labels Dec 28, 2021
@github-actions
Copy link
Contributor

Hi there,

Help us by making a minimal reproduction repository.

Before we can start work on your issue we first need to know exactly what's causing the current behavior. A minimal reproduction helps us with this.

To get started, please read our guide on creating a minimal reproduction to understand what is needed.

We may close the issue if you (or someone else) have not provided a minimal reproduction within two weeks. If you need more time, or are stuck, please ask for help or more time in a comment.

Good luck,

The Renovate team

@rarkins
Copy link
Collaborator

rarkins commented Dec 28, 2021

It sounds like something we might be able to add support for. Can you create a reproduction to begin with?

@logosmjt
Copy link
Author

According to these two issues,
#4086
#5480
is it recommended to update fileMatch?

@logosmjt
Copy link
Author

I migrated this small sample to buildSrc.

@rarkins rarkins added reproduction:provided priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others and removed auto:reproduction A minimal reproduction is necessary to proceed priority-5-triage status:requirements Full requirements are not yet known, so implementation should not be started labels Dec 30, 2021
@Goooler
Copy link

Goooler commented Feb 1, 2022

Also link #12397, #9410.

@Goooler
Copy link

Goooler commented Feb 1, 2022

I added fileMatch to renovate.json like this:

"regexManagers": [
  {
    "fileMatch": [
      "(^|/)buildSrc/.*"
    ],
    "datasourceTemplate": "gradle"
  }
],

But renovate bot told me an syntax error: Each Regex Manager must contain a non-empty matchStrings array, how can I add the matchStrings for all deps under buildSrc?

@rarkins
Copy link
Collaborator

rarkins commented Feb 1, 2022

This feature is not the right place to discuss regex manager howto's. Please raise a discussion instead, but I recommend you read more on regex manager first because I suspect you misunderstand it and shouldn't be using it for this

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
manager:gradle Gradle package manager priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others type:feature Feature (new functionality)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants