Fetching changelogs from github.com fails when the source URL contains "gitlab"

[mmslkr]

How are you running Renovate?

Self-hosted

If you're self-hosting Renovate, tell us what version of Renovate you run.

31.2.2

Please select which platform you are using if self-hosting.

GitLab self-hosted

If you're self-hosting Renovate, tell us what version of the platform you run.

31.2.2

Describe the bug

When fetching changelogs, Renovate checks the source URL to decide which API to call, see

renovate/lib/workers/pr/changelog/index.ts

Lines 30 to 38 in 74d7691

	if (
	args.sourceUrl?.includes('gitlab') ||
	(args.platform === 'gitlab' &&
	new URL(args.sourceUrl).hostname === new URL(args.endpoint).hostname)
	) {
	res = await sourceGitlab.getChangeLogJSON({ ...args, releases });
	} else {
	res = await sourceGithub.getChangeLogJSON({ ...args, releases });
	}

This breaks when fetching a URL from github.com which includes the string "gitlab", see debug logs.

A workaround right now is to uppercase "gitlab" while setting the depName.

Relevant debug logs

Logs

DEBUG: Fetching changelog: https://github.com/voxpupuli/puppet-gitlab_ci_runner (3.0.0 -> v4.2.0) (repository=lkr/test-repo)
DEBUG: Multiple candidates for changelog file, using CHANGELOG.md (repository=lkr/test-repo)
DEBUG: GitLab API 404 (repository=lkr/test-repo)
       "url": "https://github.com/api/v4/projects/voxpupuli%2fpuppet-gitlab_ci_runner/repository/tags?per_page=100"

Have you created a minimal reproduction repository?

No reproduction repository

[rarkins]

I think it's possibly the combination of also running on gitlab self-hosted too

[mmslkr]

In my case, it really is just the check for

args.sourceUrl?.includes('gitlab')

because changing the depName from voxpupuli/puppet-gitlab_ci_runner to voxpupuli/puppet-GITLAB_ci_runner solves it. But thanks for looking into it.

[github-actions]

Hi there,

Get your issue fixed faster by creating a minimal reproduction. This means a repository dedicated to reproducing this issue with the minimal dependencies and config possible.

Before we start working on your issue we need to know exactly what's causing the current behavior. A minimal reproduction helps us with this.

To get started, please read our guide on creating a minimal reproduction.

We may close the issue if you, or someone else, haven't created a minimal reproduction within two weeks. If you need more time, or are stuck, please ask for help or more time in a comment.

Good luck,

The Renovate team

[github-actions]

When a bug has been marked as needing a reproduction, it means nobody can work on it until one is provided. In cases where no reproduction is possible, or the issue creator does not have the time to reproduce, we unfortunately need to close such issues as they are non-actionable and serve no benefit by remaining open. This issue will be closed after 7 days of inactivity.

[viceice]

That code is already refactored and this should be fixed