Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: coverage issues when using re2 #12873

Closed
Tracked by #14200
RahulGautamSingh opened this issue Nov 28, 2021 · 0 comments · Fixed by #26088
Closed
Tracked by #14200

refactor: coverage issues when using re2 #12873

RahulGautamSingh opened this issue Nov 28, 2021 · 0 comments · Fixed by #26088
Labels
priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others type:refactor Refactoring or improving of existing code

Comments

@RahulGautamSingh
Copy link
Collaborator

Describe the proposed change(s).

When we use re2 at these 2 instances, it causes coverage issues.
Instance 1

handlebars.registerHelper(
'replace',
(find, replace, context) => context.replace(new RegExp(find, 'g'), replace) // TODO #12070

Instance 2
const templateRegex = /{{(#(if|unless) )?([a-zA-Z]+)}}/g; // TODO #12070

@RahulGautamSingh RahulGautamSingh added priority-5-triage status:requirements Full requirements are not yet known, so implementation should not be started type:refactor Refactoring or improving of existing code labels Nov 28, 2021
@rarkins rarkins added priority-4-low Low priority, unlikely to be done unless it becomes important to more people status:ready and removed priority-5-triage status:requirements Full requirements are not yet known, so implementation should not be started labels Nov 25, 2022
@viceice viceice added priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others and removed priority-4-low Low priority, unlikely to be done unless it becomes important to more people labels Nov 28, 2023
@renovatebot renovatebot deleted a comment from viceice Nov 28, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others type:refactor Refactoring or improving of existing code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants