-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR gets auto-merged with changed version in title, but not changed contents #12124
Comments
@rarkins Not really sure what happened there 🤔 |
The true bug is that the contents didn't change |
We are affected by the same problem. PR titles are updated, but no commit with the actual change is pushed.
Note the
|
So I guess we should try avoiding updating the PR if a branch update failed. |
any chance to have more info on why the push has failed? |
No, the error message is descriptive enough and also easily findable in the source code yourself. |
Is there any easy way we can reproduce this problem locally? One idea I have: run it in the debugger, with a pause sometime prior to the commit/push. Then intentionally edit the same branch on GitHub.com before resuming. This might be enough to cause the push --with-lease to fail. |
I'm not sure if I'm seeing the same problem on self-hosted renovate (30.0.0-slim docker) or if it's a different bug. I have a |
No, that's a different problem |
🎉 This issue has been resolved in version 31.82.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
How are you running Renovate?
WhiteSource Renovate hosted app on github.com
Please select which platform you are using if self-hosting.
github.com
If you're self-hosting Renovate, tell us what version of Renovate you run.
No response
Describe the bug
Our Dependency Dashboard 1 says:
Sequence of events:
v1.22.14
2v1.22.15
v1.22.15
but contents still atv1.22.14
v1.22.15
is merged (it is, just with wrong file contents)We still need to update to yarn
v1.22.15
in our.devcontainer/Dockerfile
file:renovate/.devcontainer/Dockerfile
Line 5 in a09231f
Relevant debug logs
I don't have access to the logs on the
renovatebot/renovate
repository, sorry!Have you created a minimal reproduction repository?
No reproduction repository
Footnotes
https://github.com/renovatebot/renovate/issues/2958 ↩
https://github.com/renovatebot/renovate/pull/12055 ↩
The text was updated successfully, but these errors were encountered: