Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Defer changelog retrieval until pr creation / update #10921

Closed
Tracked by #14138
viceice opened this issue Jul 21, 2021 · 2 comments
Closed
Tracked by #14138

Defer changelog retrieval until pr creation / update #10921

viceice opened this issue Jul 21, 2021 · 2 comments
Labels
core:changelogs Related to changelogs/release notes fetching status:requirements Full requirements are not yet known, so implementation should not be started type:feature Feature (new functionality)

Comments

@viceice
Copy link
Member

viceice commented Jul 21, 2021

What would you like Renovate to be able to do?

Currently renovate will fetch changelogs before any branch exists. So it should defer fetching changelogs until we know we create / update a pr.

INFO: Dependency extraction complete
{
  "baseBranch": "main",
  "stats": {
    "managers": {
      "github-actions": {
        "fileCount": 1,
        "depCount": 5
      },
      "nuget": {
        "fileCount": 13,
        "depCount": 37
      }
    },
    "total": {
      "fileCount": 14,
      "depCount": 42
    }
  }
}
DEBUG: Release 3.1.0 is pending status checks
{
  "depName": "coverlet.collector",
  "check": "stabilityDays"
}
DEBUG: All releases are pending - using latest
{
  "depName": "coverlet.collector",
  "bucket": "minor"
}
DEBUG: Package releases lookups complete
{
  "baseBranch": "main"
}
DEBUG: branchifyUpgrades
DEBUG: Using group branchName template
DEBUG: Dependency System.Text.Encoding.CodePages is part of group dotnet monorepo
DEBUG: Using group branchName template
DEBUG: Dependency System.Security.Cryptography.Pkcs is part of group dotnet monorepo
DEBUG: Using group branchName template
DEBUG: Dependency System.Drawing.Common is part of group dotnet monorepo
DEBUG: Using group branchName template
DEBUG: Dependency Microsoft.Extensions.Configuration.Json is part of group dotnet monorepo
DEBUG: Using group branchName template
DEBUG: Dependency System.Text.Encoding.CodePages is part of group dotnet monorepo
DEBUG: Using group branchName template
DEBUG: Dependency System.Security.Cryptography.Pkcs is part of group dotnet monorepo
DEBUG: Using group branchName template
DEBUG: Dependency System.Drawing.Common is part of group dotnet monorepo
DEBUG: Using group branchName template
DEBUG: Dependency Microsoft.Extensions.Configuration.Json is part of group dotnet monorepo
DEBUG: 10 flattened updates found: System.Text.Encoding.CodePages, System.Security.Cryptography.Pkcs, System.Drawing.Common, Microsoft.Extensions.Configuration.Json, System.Text.Encoding.CodePages, System.Security.Cryptography.Pkcs, System.Drawing.Common, Microsoft.Extensions.Configuration.Json, coverlet.collector, FakeItEasy
DEBUG: Returning 3 branch(es)
DEBUG: Fetching changelog: https://github.com/dotnet/runtime (3.1.17 -> 5.0.0)
DEBUG: Fetching changelog: https://github.com/dotnet/runtime (4.7.2 -> 5.0.2)
DEBUG: Fetching changelog: https://github.com/dotnet/runtime (4.7.0 -> 5.0.1)
DEBUG: Fetching changelog: https://github.com/dotnet/runtime (4.7.1 -> 5.0.0)
DEBUG: Fetching changelog: https://github.com/dotnet/runtime (3.1.17 -> 5.0.0)
DEBUG: Fetching changelog: https://github.com/dotnet/runtime (4.7.2 -> 5.0.2)
DEBUG: Fetching changelog: https://github.com/dotnet/runtime (4.7.0 -> 5.0.1)
DEBUG: Fetching changelog: https://github.com/dotnet/runtime (4.7.1 -> 5.0.0)
DEBUG: Fetching changelog: https://github.com/coverlet-coverage/coverlet (3.0.3 -> 3.1.0)
DEBUG: Fetching changelog: https://github.com/FakeItEasy/FakeItEasy (6.2.1 -> 7.1.0)
DEBUG: config.repoIsOnboarded=true

Did you already have any implementation ideas?

@viceice viceice added type:feature Feature (new functionality) status:requirements Full requirements are not yet known, so implementation should not be started priority-5-triage labels Jul 21, 2021
@viceice viceice changed the title Defer changelog retrival until pr creation / update Defer changelog retrieval until pr creation / update Jul 21, 2021
@viceice
Copy link
Member Author

viceice commented Jul 21, 2021

@rarkins
Copy link
Collaborator

rarkins commented Jul 22, 2021

This was an intentional change as about shyest ago IIRC although maybe it was made earlier than it needs. Someone wanted access to the release notes for the commit message body

@HonkingGoose HonkingGoose added the core:changelogs Related to changelogs/release notes fetching label Sep 1, 2021
@rarkins rarkins closed this as completed Nov 25, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
core:changelogs Related to changelogs/release notes fetching status:requirements Full requirements are not yet known, so implementation should not be started type:feature Feature (new functionality)
Projects
None yet
Development

No branches or pull requests

3 participants