-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changelog containing '</details>' breaks pr formatting #10143
Comments
Hi there, The Renovate team needs your help! Before we can start work on your issue we first need to know exactly what's causing the current behavior. A minimal reproduction helps us with this. To get started, please read our guide on minimal reproductions to understand what is needed. We may close the issue if you have not provided a minimal reproduction within two weeks. If you need more time, or are stuck, please ask for help or more time in a comment. Good luck, The Renovate team |
Are you aware of any open source package which has included this in a recent changelog? |
I created an example |
You should also checkout our gitlab pipeline templates for at https://gitlab.com/renovate-bot/renovate-runner |
@viceice Thanks, but I'm currently using a private gitlab instance with Jenkins as my runner in a corporate environment. The repo above is just a quick one I threw together to demonstrate. |
Which version did you run? |
This comment has been minimized.
This comment has been minimized.
I ran it again with a local version of |
@dsbert Did you checked the rebase checkbox before you run with latest version, so renovate did a force update? |
I think Renovate will always update PR bodies regardless of whether it's rebasing |
I actually deleted the old pr completely so it definitely updated. |
Thank you for providing a reproduction! 🎉 🚀 The Renovate team will take a look at the reproduction repository. Once we confirm the provided repository reproduces the problem, the label will be changed to |
Is this still an issue? |
How are you running Renovate?
If using the hosted app, please skip to the next section.
Otherwise, if self-hosted, please complete the following:
Please select which platform you are using:
Renovate version: 25.21.12
Describe the bug
The renovate changelog contains
</details>
. This is not escaped so when the PR is created, the collapsed changelog formatting breaks. This could happen with any other project obviously, but this projects changelog is an easy example. I'm not sure if it makes sense to scan the changelogs and escape this everywhere, but it might at least make sense to escape that somehow in this specific changelog....
Relevant debug logs
Have you created a minimal reproduction repository?
Please read the minimal reproductions documentation to learn how to make a good minimal reproduction repository.
https://gitlab.com/dsbert/renovate-bot/-/merge_requests/2
Additional context
The text was updated successfully, but these errors were encountered: