-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add node language version #2628
base: main
Are you sure you want to change the base?
Conversation
What about
It will ensure to stay on LTS instead of unsupported active version |
@jonesbusy did not know that this feature existed. Do you know that this works? Do you have any example/documentation where this is mentioned? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
needs updated renovate config as mentioned in issue.
is this a fixed version or can we use a range? will that version automatically downloaded?
https://pre-commit.com/#overriding-language-version The I've just tested nodeenv --node=lts .test
* Install prebuilt node (22.12.0) ..... done. |
Changed to @viceice what would have to be changed in the renovate config? |
does it support setting the major version only? because renovate sometimes doesn't support the newest lts for some time. |
Apparently not I tried without success
|
Being said that you don't always support the latest LTS version, we might want to explicitly specify the node version to be used. This way, you can explicitly define what should be used and is supported. If this becomes to much manual effort, maybe renovate can autoupdate this as well. WDYT @viceice. |
Closes #2460
This avoids that pre-commit picks the latest node version available that might not be supported by renovate. Users can still override this if they want.