-
Notifications
You must be signed in to change notification settings - Fork 104
Point the launcher at the new build system #557
Comments
We might just have the new build process emit the same data that the Jenkins build did previously, at which point the launcher will just go back to working. I don't recall offhand what all it fetches or if it tries to fetch anything directly from narc.ro, so it'll take a little digging. CDDA-Game-Launcher/cddagl/ui/views/main.py Line 3214 in 2e24f26
So that will definitely need to be changed to get it working again. |
The launcher should be able to get the new builds with this recents change: f57b318 . It will be part of the next release. I'm currently improving the executable bundle process so it will be less likely to trigger AV products. This might take a little while. |
To be clear, it should be pretty straightforward to get the new build artifacts from the github release API, but the more iffy thing is the changelog since that was being served by narc.ro and we don't have a 1:1 replacement for that. |
Doesn't the build action occur every time there's a commit? Use the commit message as the changelog. |
The changelog has been removed when selecting the experimental branch until there is a replacement. |
No, it is triggered on merge, which can be an arbitrary number of commits, and we just pushed a change that prevents overlapping releases, so there will be multiple merges per release if they're fast enough. What I'm thinking is the list of commit messages can either be retrieved from the github API or maybe we can write it to the description of the release. |
It looks like the commit span doesn't make it into the release by default, so we need to capture something during the release process and write it to the release. |
New experimental release tag naming scheme:
New experimental release artifact naming scheme:
|
I guess we'll need another update 😄 |
The new tag will break our ability to search by build number if it includes the date. We can easily search for build but we cannot search for build We can adjust for the date being in the asset name without any issue. Just that the tag naming will cause some issues. |
Or maybe we could use the full date and number at the end as the build number. |
This should be taken care of in 546fe9b |
You can allow entering hyphens in addition to numbers to "Find build #" field (or use mask). |
Is your feature request related to a problem? Please describe.
With the Jenkins build bot being migrated away from in favor of Github actions, the launcher can no longer be used to update the game.
Describe the solution you'd like
Point the launcher at the new build system.
Describe alternatives you've considered
I dunno. I could learn enough python to do it myself, I guess? That may take a while, and it sounds like a lot of work.
Additional context
Add any other context or screenshots about the feature request here.
The text was updated successfully, but these errors were encountered: