fix: restart on change for non-default signals (#1409) #1430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This issue has been automatically marked as idle and stale because it hasn't had any recent activity. It will be automtically closed if no further activity occurs. If you think this is wrong, or the problem still persists, just pop a reply in the comments and @remy will (try!) to follow up. |
|
Not stale. Please merge. |
|
Can't merge until it passes the tests I'm afraid. |
aaronjensen
force-pushed
the
fix/restart-on-change
branch
from
202c01a
to
64aacfb
Compare
|
No idea how I missed your comment nor how this change would have broken a test, but I'll take a look. |
When nodemon kills the child app in preparation for a restart, the app may exit with a non-zero status code, especially when using custom signals like SIGINT. Previously, this would be detected as a clean exit rather than a restart, at least on macOS. There was an existing flag, `killedAfterChange` which causes the desired behavior, but it was only set on Windows. It seems that setting it always leaked between tests and caused problems, so we only set it if a restart is expected. Fixes remy#1409
aaronjensen
force-pushed
the
fix/restart-on-change
branch
from
64aacfb
to
0b9e9fd
Compare
|
@remy thanks for pointing out the failures. Fixed. Also added a test for the original issue. Cheers! |
This was referenced Nov 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1409